From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NqPAA-0005HL-Mm
	for qemu-devel@nongnu.org; Sat, 13 Mar 2010 06:05:46 -0500
Received: from [199.232.76.173] (port=39819 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NqPAA-0005H0-67
	for qemu-devel@nongnu.org; Sat, 13 Mar 2010 06:05:46 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <aurelien@aurel32.net>) id 1NqPA8-0000Ao-OM
	for qemu-devel@nongnu.org; Sat, 13 Mar 2010 06:05:45 -0500
Received: from hall.aurel32.net ([88.191.82.174]:39599)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <aurelien@aurel32.net>)
	id 1NqPA8-0000Ag-Ch
	for qemu-devel@nongnu.org; Sat, 13 Mar 2010 06:05:44 -0500
Date: Sat, 13 Mar 2010 12:05:41 +0100
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] Re: [RESEND][PATCH][STABLE] Fix corner case in
	chardev udp: parameter
Message-ID: <20100313110541.GD26216@hall.aurel32.net>
References: <4B937FE0.5080609@siemens.com> <4B952975.6000605@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <4B952975.6000605@codemonkey.ws>
Sender: Aurelien Jarno <aurelien@aurel32.net>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel <qemu-devel@nongnu.org>, Gerd Hoffmann <kraxel@redhat.com>

On Mon, Mar 08, 2010 at 10:44:37AM -0600, Anthony Liguori wrote:
> On 03/07/2010 04:28 AM, Jan Kiszka wrote:
>> The missing '@' broke 'udp::<port>@:<port>' parsing.
>>
>> Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com>
>>    
>
> Applied to stable, thanks.


The same problem exists in HEAD. Shouldn't it be applied here too?

>
> Regards,
>
> Anthony Liguori
>
>> ---
>>   qemu-char.c |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/qemu-char.c b/qemu-char.c
>> index 86c7c5a..0d8553d 100644
>> --- a/qemu-char.c
>> +++ b/qemu-char.c
>> @@ -2333,7 +2333,7 @@ QemuOpts *qemu_chr_parse_compat(const char *label, const char *filename)
>>           qemu_opt_set(opts, "backend", "udp");
>>           if (sscanf(p, "%64[^:]:%32[^@,]%n", host, port,&pos)<  2) {
>>               host[0] = 0;
>> -            if (sscanf(p, ":%32[^,]%n", port,&pos)<  1) {
>> +            if (sscanf(p, ":%32[^@,]%n", port,&pos)<  1) {
>>                   goto fail;
>>               }
>>           }
>>
>>    
>
>
>
>

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net