From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NqTba-0005Ji-4Z for qemu-devel@nongnu.org; Sat, 13 Mar 2010 10:50:22 -0500 Received: from [199.232.76.173] (port=58972 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NqTbZ-0005Ja-Ad for qemu-devel@nongnu.org; Sat, 13 Mar 2010 10:50:21 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NqTbX-0006hj-Im for qemu-devel@nongnu.org; Sat, 13 Mar 2010 10:50:21 -0500 Received: from hall.aurel32.net ([88.191.82.174]:54240) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NqTbX-0006hR-9T for qemu-devel@nongnu.org; Sat, 13 Mar 2010 10:50:19 -0500 Date: Sat, 13 Mar 2010 16:50:12 +0100 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH 00/13] x86/cpuid: cleanups and fixes Message-ID: <20100313155012.GG26216@hall.aurel32.net> References: <1268314747-11111-1-git-send-email-andre.przywara@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1268314747-11111-1-git-send-email-andre.przywara@amd.com> Sender: Aurelien Jarno List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andre Przywara Cc: qemu-devel@nongnu.org On Thu, Mar 11, 2010 at 02:38:54PM +0100, Andre Przywara wrote: > Hi, > > a rebased and refined version of my CPUID cleanup series. This should > now apply on top of git head. Compared to the last post this leaves > out the bits already done by John Cooper's patch. Also I added a separate > patch to deal with an accidently removed line (patch 3/13). > > This patchset cleans up the CPUID handling code in QEMU. The biggest change > is obviously the move of the CPUID function to a separate file (cpuid.c). > This helps to split up a rather large source file, which's name (helper.c) is > also a bit misleading. > Additionally the rest of the patches beautifies or simplifies some code. > Feature additions are: > 5/13: add missing CPUID feature bit names (updated) > 8/13: -cpu host propagates more CPUID leafs, so that the cache topology > will be visibile in the guest > 9/13: add CPUID feature bit trimming for TCG: Features not supported by > the emulator will be masked out. > 10/13: always show all CPU types: also expose the newer (64bit) CPU types > for the i386 emulator. 64bit features will be masked out due to 9/13. > 11/13: add kvm32 CPU model: Per popular request add a counterpart to kvm64 > describing a basic hardware virtualization capable CPU for migration > purposes. > 13/13: Set the feature bits of qemu{32,64} to the set supported by TCG. > > The last patch is actually debatable, as it changes the default CPUID bits > seen by guest. On the other hand it is only consequent to do so, as > qemu{32,64} are meant to be artifical CPUs. > > More details in the commit messages. > > Please review, comment and apply. > Thanks, I have applied all patches except: - 08: I prefer someone knowing KVM better than me reviews it - 11: same - 13: See comment from Jamie -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net