From: Frederic Weisbecker <fweisbec@gmail.com>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org, Mike Galbraith <efault@gmx.de>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 2/2] perf hist: Don't fprintf the callgraph unconditionally
Date: Sun, 14 Mar 2010 15:34:07 +0100 [thread overview]
Message-ID: <20100314143405.GB5312@nowhere> (raw)
In-Reply-To: <20100314142152.GG6965@ghostprotocols.net>
On Sun, Mar 14, 2010 at 11:21:52AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Sun, Mar 14, 2010 at 10:47:34AM +0100, Frederic Weisbecker escreveu:
> > Hmm, so for now the callchain won't work anymore until
> > it gets properly reimplemented right?
>
> It doesn't work in the newt interface only, it remais working if you do:
>
> perf report | less
> perf report > output.txt
> rpm -e newt-devel ; make -C tools/perf install
>
> :-)
Aah!
> > Not that much a problem as a necessary step if it really makes
> > easier for the newt integration.
>
> This patch doesn't change the situation before it, i.e. callgraphs _in
> the newt interface_ weren't working.
Ok :-)
next prev parent reply other threads:[~2010-03-14 14:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-12 15:46 [PATCH 1/2] perf newt: Use newtGetScreenSize Arnaldo Carvalho de Melo
2010-03-12 15:46 ` [PATCH 2/2] perf hist: Don't fprintf the callgraph unconditionally Arnaldo Carvalho de Melo
2010-03-14 9:47 ` Frederic Weisbecker
2010-03-14 14:21 ` Arnaldo Carvalho de Melo
2010-03-14 14:34 ` Frederic Weisbecker [this message]
2010-03-14 14:47 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100314143405.GB5312@nowhere \
--to=fweisbec@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.