All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aurelien Jarno <aurelien@aurel32.net>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] load_elf: replace the address addend by a translation function
Date: Sun, 14 Mar 2010 23:17:27 +0100	[thread overview]
Message-ID: <20100314221727.GG2381@hall.aurel32.net> (raw)
In-Reply-To: <201003142159.45411.paul@codesourcery.com>

Thanks for the review.

On Sun, Mar 14, 2010 at 09:59:44PM +0000, Paul Brook wrote:
> > The patch also convert all machines that have an addend, simplify the
> > PowerPC kernel loading 
> 
> The new PPC code looks like it may break images > 16M in size.

The idea was to get rid of the most significant byte, as it changes
depending on the kernel version, while we want the kernel to be loaded
at a fixed address. Looks like I have to shift the mask by four bits.

> > and fix the MIPS kernel loading using this new
> > feature.
> 
> I'm fairly sure the MIPS routines are not board specific, so it'd be nice if 
> we could avoid the duplication.  This would also reduce pain if we implement 
> loading to other segments (in particular kseg1 and xkphys).
> 

Good idea.

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net

  reply	other threads:[~2010-03-14 22:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-14 20:57 [Qemu-devel] [PATCH] load_elf: replace the address addend by a translation function Aurelien Jarno
2010-03-14 21:59 ` Paul Brook
2010-03-14 22:17   ` Aurelien Jarno [this message]
2010-03-14 22:55     ` Paul Brook
2010-03-14 23:13       ` Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100314221727.GG2381@hall.aurel32.net \
    --to=aurelien@aurel32.net \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.