diff for duplicates of <20100315101146.GL18181@bicker> diff --git a/a/1.txt b/N1/1.txt index edb8086..1cbc943 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -11,7 +11,8 @@ No problem, I'm happy to explain. 642 int i; 643 644 for (i = 0; i < BITS_TO_LONGS(IB_MGMT_MAX_METHODS); ++i) - 645 req.method_mask[i] 646 umm[i * 2] | ((u64) umm[i * 2 + 1] << 32); + 645 req.method_mask[i] = + 646 umm[i * 2] | ((u64) umm[i * 2 + 1] << 32); "umm" points to a array with 4 elements. i can be 0 to 3, so "i * 2" goes up to 6 And 4 <= 6 so it's a problem. @@ -21,9 +22,9 @@ Smatch also complained about "i * 2 + 1" but I didn't include that. 184 static const int rate[]={-1,1,2,3,5,7,-1}; [snip] 192 if (fec>FEC_AUTO) - 193 fecþC_AUTO; + 193 fec=FEC_AUTO; 194 - 195 if (fec=FEC_AUTO) { /* (re-)establish AutoAcq behaviour */ + 195 if (fec==FEC_AUTO) { /* (re-)establish AutoAcq behaviour */ [snip] 207 } else { 208 cx24110_writereg(state,0x37,cx24110_readreg(state,0x37)|0x20); @@ -32,7 +33,7 @@ Smatch also complained about "i * 2 + 1" but I didn't include that. "rate" has 7 elements. FEC_AUTO - 1 is 8. 7 <= 8. > drivers/video/cyber2000fb.c +330 cyber2000fb_setcolreg() 'cfb->palette' 256 <= 504 - 316 if (var->green.length = 6 && regno < 64) { + 316 if (var->green.length == 6 && regno < 64) { 317 cfb->palette[regno << 2].green = green; [snip] 330 green = cfb->palette[regno << 3].green; @@ -43,7 +44,7 @@ Smatch also complained about "i * 2 + 1" but I didn't include that. 626 if (snd_BUG_ON(voice >= MAX_OPL3_VOICES)) 627 return; [snip] - 651 if (vp->state = SNDRV_OPL3_ST_ON_4OP) { + 651 if (vp->state == SNDRV_OPL3_ST_ON_4OP) { 652 vp2 = &opl3->voices[voice + 3]; "opl3->voices" has 18 elements. "voice" can be 17. 17 + 3 is 20. @@ -72,7 +73,3 @@ dan carpenter > Toralf Förster > > pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3 --- -To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 7c90398..34ee1d9 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\0201003151002.18928.toralf.foerster@gmx.de\0" "From\0Dan Carpenter <error27@gmail.com>\0" "Subject\0Re: bug list: range checking issues 2.6.34-rc1\0" - "Date\0Mon, 15 Mar 2010 10:45:23 +0000\0" + "Date\0Mon, 15 Mar 2010 13:45:23 +0300\0" "To\0Toralf F\303\266rster <toralf.foerster@gmx.de>\0" "Cc\0linux-kernel@vger.kernel.org" " kernel-janitors@vger.kernel.org\0" @@ -20,7 +20,8 @@ " 642 int i;\n" " 643 \n" " 644 for (i = 0; i < BITS_TO_LONGS(IB_MGMT_MAX_METHODS); ++i)\n" - " 645 req.method_mask[i] 646 umm[i * 2] | ((u64) umm[i * 2 + 1] << 32);\n" + " 645 req.method_mask[i] =\n" + " 646 umm[i * 2] | ((u64) umm[i * 2 + 1] << 32);\n" "\"umm\" points to a array with 4 elements.\n" "i can be 0 to 3, so \"i * 2\" goes up to 6\n" "And 4 <= 6 so it's a problem.\n" @@ -30,9 +31,9 @@ " 184 static const int rate[]={-1,1,2,3,5,7,-1};\n" "\t[snip]\n" " 192 if (fec>FEC_AUTO)\n" - " 193 fec\303\276C_AUTO;\n" + " 193 fec=FEC_AUTO;\n" " 194 \n" - " 195 if (fec=FEC_AUTO) { /* (re-)establish AutoAcq behaviour */\n" + " 195 if (fec==FEC_AUTO) { /* (re-)establish AutoAcq behaviour */\n" "\t[snip]\n" " 207 } else {\n" " 208 cx24110_writereg(state,0x37,cx24110_readreg(state,0x37)|0x20);\n" @@ -41,7 +42,7 @@ "\"rate\" has 7 elements. FEC_AUTO - 1 is 8. 7 <= 8.\n" "\n" "> drivers/video/cyber2000fb.c +330 cyber2000fb_setcolreg() 'cfb->palette' 256 <= 504\n" - " 316 if (var->green.length = 6 && regno < 64) {\n" + " 316 if (var->green.length == 6 && regno < 64) {\n" " 317 cfb->palette[regno << 2].green = green;\n" "\t[snip]\n" " 330 green = cfb->palette[regno << 3].green;\n" @@ -52,7 +53,7 @@ " 626 if (snd_BUG_ON(voice >= MAX_OPL3_VOICES))\n" " 627 return;\n" "\t[snip]\n" - " 651 if (vp->state = SNDRV_OPL3_ST_ON_4OP) {\n" + " 651 if (vp->state == SNDRV_OPL3_ST_ON_4OP) {\n" " 652 vp2 = &opl3->voices[voice + 3];\n" "\"opl3->voices\" has 18 elements. \"voice\" can be 17. 17 + 3 is 20.\n" "\n" @@ -80,10 +81,6 @@ "> MfG/Sincerely\n" "> Toralf F\303\266rster\n" "> \n" - "> pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe kernel-janitors\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + > pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3 -4ef3e4ecff397884c9a939714ff5cbf59866b6a59c26c673982148de2b0d59d1 +7481081a2a0f7c22b057d439cc6d37ddc62cdaa57cbe9ee0c573a54920afbb72
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.