From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH 0/5] Fix some mmu/emulator atomicity issues (v2) Date: Mon, 15 Mar 2010 07:16:39 -0300 Message-ID: <20100315101639.GA31813@amt.cnet> References: <1268232631-1579-1-git-send-email-avi@redhat.com> <4B9C8A53.8030902@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:11930 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936064Ab0COKRX (ORCPT ); Mon, 15 Mar 2010 06:17:23 -0400 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2FAHM5W025175 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 15 Mar 2010 06:17:23 -0400 Content-Disposition: inline In-Reply-To: <4B9C8A53.8030902@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Sun, Mar 14, 2010 at 09:03:47AM +0200, Avi Kivity wrote: > On 03/10/2010 04:50 PM, Avi Kivity wrote: > >Currently when we emulate a locked operation into a shadowed guest page > >table, we perform a write rather than a true atomic. This is indicated > >by the "emulating exchange as write" message that shows up in dmesg. > > > >In addition, the pte prefetch operation during invlpg suffered from a > >race. This was fixed by removing the operation. > > > >This patchset fixes both issues and reinstates pte prefetch on invlpg. > > > >v2: > > - fix truncated description for patch 1 > > - add new patch 4, which fixes a bug in patch 5 > > No comments, but looks like last week's maintainer neglected to merge this. Looks fine. Can you please regenerate against next branch? (just pushed). For the invlpg prefetch it would be good to confirm the original bug is not reproducible.