From: Matthias-Christian Ott <ott@mirix.org>
To: linux-pm@lists.linux-foundation.org
Subject: Re: [PATCH 2/2] e1000e / PCI / PM: Add basic runtime PM support (rev. 4)
Date: Mon, 15 Mar 2010 12:41:18 +0100 [thread overview]
Message-ID: <20100315114117.GA1764@qp> (raw)
In-Reply-To: <201003150135.17564.rjw@sisk.pl>
On Mon, Mar 15, 2010 at 01:35:17AM +0100, Rafael J. Wysocki wrote:
> +static bool e1000e_pm_ready(struct e1000_adapter *adapter)
> +{
> + return !!adapter->tx_ring->buffer_info;
> +}
Are your sure the double negation is right?
Regards,
Matthias-Christian
next prev parent reply other threads:[~2010-03-15 11:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-15 0:31 [PATCH 0/2] PCI runtime power management for r8169 and e1000e Rafael J. Wysocki
2010-03-15 0:33 ` [PATCH 1/2] r8169 / PCI / PM: Add simplified runtime PM support (rev. 3) Rafael J. Wysocki
2010-03-15 0:33 ` Rafael J. Wysocki
2010-03-17 4:29 ` David Miller
2010-03-17 4:29 ` David Miller
2010-03-15 0:35 ` [PATCH 2/2] e1000e / PCI / PM: Add basic runtime PM support (rev. 4) Rafael J. Wysocki
2010-03-15 11:41 ` Matthias-Christian Ott [this message]
2010-03-15 19:28 ` Rafael J. Wysocki
2010-03-17 4:29 ` David Miller
2010-03-17 4:29 ` David Miller
2010-03-15 0:35 ` Rafael J. Wysocki
2010-04-22 20:19 ` [PATCH 0/2] PCI runtime power management for r8169 and e1000e Markus Feldmann
2010-04-22 20:59 ` Markus Feldmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100315114117.GA1764@qp \
--to=ott@mirix.org \
--cc=linux-pm@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.