From: Alan Cox <alan@linux.intel.com>
To: Dominik Brodowski <linux@dominikbrodowski.net>
Cc: Jan Beulich <JBeulich@novell.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: pcmcia's use of IRQ_NOAUTOEN
Date: Mon, 15 Mar 2010 17:43:59 +0000 [thread overview]
Message-ID: <20100315174359.7fa53d4b@linux.intel.com> (raw)
In-Reply-To: <20100308194757.GB17628@isilmar.linta.de>
On Mon, 8 Mar 2010 20:47:57 +0100
Dominik Brodowski <linux@dominikbrodowski.net> wrote:
> Hey,
>
> On Mon, Mar 08, 2010 at 10:17:11AM +0000, Jan Beulich wrote:
> > (re-sending to correct Alan's email address)
> >
> > Commit 635416ef393e8cec5a89fc6c1de710ee9596a51e introduced
> > this, but I can't see how it can take effect - the argument passed
> > to request_irq() only affects action->flags (IRQF_*), whereas the
> > flag in question is a desc->status one (IRQ_*). Am I overlooking
> > something? If not, while currently this just should not work as
> > expected, it's latently more significant (as soon as the IRQF_*
> > definitions make use of the bit used by IRQ_NOAUTOEN).
>
> You're right, it seems to make no sense. Or less than that.
>
> Alan, what do you think?
It should be setting the correct NOAUTOEN bits so that the IRQ isn't
randomly enabled as some hardware then crashes. How it ended up wrong
upstream I don't know as it was tested and fixed the bug, so presumably
the right version got tested or it happened to work back on the old irq
code by luck.
I don't think you are overlooking anything - there is no deep magic
involved.
Alan
next prev parent reply other threads:[~2010-03-15 18:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-08 10:17 pcmcia's use of IRQ_NOAUTOEN Jan Beulich
2010-03-08 19:47 ` Dominik Brodowski
2010-03-15 17:43 ` Alan Cox [this message]
2010-03-15 18:18 ` Dominik Brodowski
-- strict thread matches above, loose matches on Subject: below --
2010-03-08 10:11 Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100315174359.7fa53d4b@linux.intel.com \
--to=alan@linux.intel.com \
--cc=JBeulich@novell.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.