From: Greg KH <gregkh@suse.de>
To: Jaswinder Singh Rajput <jaswinderlinux@gmail.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>, Greg KH <greg@kroah.com>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] Driver core: Reduce the level of request_firmware() messages
Date: Mon, 15 Mar 2010 16:44:24 -0700 [thread overview]
Message-ID: <20100315234424.GA4008@suse.de> (raw)
In-Reply-To: <3f9a31f41003151634k5f8521c0l99179bcf02d9e551@mail.gmail.com>
On Tue, Mar 16, 2010 at 05:04:09AM +0530, Jaswinder Singh Rajput wrote:
> Hello Rafael,
>
> On Tue, Mar 16, 2010 at 2:57 AM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> >
> > I still think it's a good idea. The information about what firmware is being
> > used doesn't seem to be very useful for anything but debugging, so I think
> > KERN_DEBUG is actually the right level for these messages.
> >
>
> Can we use printk_once()
No, I'd rather use dev_dbg() that way we can dynamically turn it on and
off as needed. I took Rafael's original patch.
Funny thing is, someone else also sent the same patch, so there must be
others wanting this change :)
thanks,
greg k-h
next prev parent reply other threads:[~2010-03-15 23:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-27 20:43 [PATCH] Driver core: Reduce the level of request_firmware() messages Rafael J. Wysocki
2010-02-28 3:13 ` Greg KH
2010-02-28 4:43 ` Jaswinder Singh Rajput
2010-02-28 12:13 ` Rafael J. Wysocki
2010-02-28 16:33 ` Jaswinder Singh Rajput
2010-02-28 19:54 ` Rafael J. Wysocki
2010-02-28 20:13 ` Jaswinder Singh Rajput
2010-03-15 20:16 ` Greg KH
2010-03-15 21:27 ` Rafael J. Wysocki
2010-03-15 23:34 ` Jaswinder Singh Rajput
2010-03-15 23:40 ` Rafael J. Wysocki
2010-03-15 23:55 ` Jaswinder Singh Rajput
2010-03-15 23:44 ` Greg KH [this message]
2010-03-16 0:17 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100315234424.GA4008@suse.de \
--to=gregkh@suse.de \
--cc=akpm@linux-foundation.org \
--cc=dwmw2@infradead.org \
--cc=greg@kroah.com \
--cc=jaswinderlinux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.