From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [RFC] Delayed logging
Date: Tue, 16 Mar 2010 12:14:03 +1100 [thread overview]
Message-ID: <20100316011403.GB12369@dastard> (raw)
In-Reply-To: <20100315160801.GB10406@infradead.org>
On Mon, Mar 15, 2010 at 12:08:01PM -0400, Christoph Hellwig wrote:
> Some comments on the patches:
>
> - "xfs: cluster fsync transaction" seems like something that can stand
> on it's own and go into the tree now. Despite the comments it
> currently only clusters in fsync and not write_inode which might
> lead to higher benefits, btw.
As I said, I'll have a bit more of a think about this one...
> - the busy extent tracking might be worth to be reordered before the
> delayed logging series. In itself it might also want some reordering
> as there's a lot churn in the patches there. Making
> "XFS: Simplify transaction busy extent tracking" first in that
> subseries might help quite a bit to reduce that churn
Agreed. They were ordered this way because I only added the extent
tracking after doing the delayed logging and tracking down one of
the sources of log forces that was limiting performance was
overflowing the per-ag busy extent array. I'll rework it....
> - The actual CIL implementation seems to be split into too small
> patches IMHO. E.g. "xfs: extend the log item to support delayed
> logging" and "xfs: Introduce the Committed Item List" are two
> sides of the same coin and splitting it might not make too much
> sense.
True, it might be a bit fine grained. Really, what I wanted to do is
split the changes that affected the non-delayed logging from those
that are only executed when delayed logging is active. That way I
could confirm that the non-delayed path was still operating
correctly before adding all the delayed logging code that used
it. I can combine them together again if you want.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-03-16 1:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-15 4:30 [RFC] Delayed logging Dave Chinner
2010-03-15 16:01 ` Christoph Hellwig
2010-03-15 16:33 ` Christoph Hellwig
2010-03-16 1:06 ` Dave Chinner
2010-03-15 16:08 ` Christoph Hellwig
2010-03-16 1:14 ` Dave Chinner [this message]
2010-03-15 16:38 ` Christoph Hellwig
2010-03-16 1:15 ` Dave Chinner
2010-03-15 18:08 ` Christoph Hellwig
2010-03-16 1:20 ` Dave Chinner
2010-03-31 13:26 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100316011403.GB12369@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.