From: Lars Damerow <lars@pixar.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH] Add support for GIT_ONE_FILESYSTEM
Date: Mon, 15 Mar 2010 22:56:25 -0700 [thread overview]
Message-ID: <20100316055625.GA10907@pixar.com> (raw)
In-Reply-To: <7vbpeovqyi.fsf@alter.siamese.dyndns.org>
>From Junio C Hamano <gitster@pobox.com>, Mon, Mar 15, 2010 at 09:19:17PM -0700:
>
> How inefficient is it to repeatedly call getenv() in a loop, by the way?
> I think the patch would become easier to read if env_bool() is called once
> at the beginning to set a local variable, and not even do the initial stat()
> for "." if this feature is not asked for.
Agreed, I didn't do this too efficiently. Thanks for the feedback! I'll
make a new patch and resubmit.
cheers,
-lars
--
lars r. damerow :: button pusher :: pixar animation studios
When in doubt, use brute force.
prev parent reply other threads:[~2010-03-16 5:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-15 21:40 [PATCH] Add support for GIT_ONE_FILESYSTEM Lars Damerow
2010-03-15 23:16 ` Sverre Rabbelier
2010-03-15 23:36 ` Lars Damerow
2010-03-16 2:33 ` Jeff King
2010-03-16 3:28 ` Lars Damerow
2010-03-16 3:37 ` Jeff King
2010-03-16 4:19 ` Junio C Hamano
2010-03-16 5:56 ` Lars Damerow [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100316055625.GA10907@pixar.com \
--to=lars@pixar.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.