From: Greg KH <greg@kroah.com>
To: NeilBrown <neilb@suse.de>
Cc: Greg KH <gregkh@suse.de>, Mimi Zohar <zohar@us.ibm.com>,
"Serge E . Hallyn" <serue@us.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kref: remove kref_set
Date: Tue, 16 Mar 2010 10:54:23 -0700 [thread overview]
Message-ID: <20100316175423.GA23303@kroah.com> (raw)
In-Reply-To: <19359.1467.612457.401272@notabene.brown>
On Tue, Mar 16, 2010 at 03:14:51PM +1100, NeilBrown wrote:
>
>
> Of the three uses of kref_set in the kernel:
>
> One really should be kref_put as the code is letting go of a
> reference,
> Two really should be kref_init because the kref is being
> initialised.
>
> This suggests that making kref_set available encourages bad code.
> So fix the three uses and remove kref_set completely.
Yeah!
I really didn't like kref_set at all anyway, and I thought that someone
"required it" which is why it was added. Oh well, I'm glad it is now
gone, thanks so much for this patch.
greg k-h
prev parent reply other threads:[~2010-03-16 17:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-16 4:14 [PATCH] kref: remove kref_set NeilBrown
2010-03-16 13:31 ` Serge E. Hallyn
2010-03-16 15:15 ` Mimi Zohar
2010-03-16 17:54 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100316175423.GA23303@kroah.com \
--to=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=serue@us.ibm.com \
--cc=zohar@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.