All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Cc: Alex Chiang <achiang@hp.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] small xhci cleanups
Date: Tue, 16 Mar 2010 14:40:14 -0700	[thread overview]
Message-ID: <20100316214014.GA8839@kroah.com> (raw)
In-Reply-To: <20100316212445.GA15729@xanatos>

On Tue, Mar 16, 2010 at 02:24:45PM -0700, Sarah Sharp wrote:
> Ok, I didn't see Greg's email about dynamic debugging.  I guess you
> shouldn't refresh the second patch.  I'm not sure how I would go about
> converting the xHCI driver to dynamic debugging, as I haven't looked
> into it.  Is there any documentation/simple examples?

Yes, just use 'dev_dbg' and you are finished.

Or pr_debug if you want to use different logging levels with your
macros.

> Greg, does the less-verbose patch with log levels still make sense if
> the driver got converted over to dynamic debugging?

I don't know what people really want to see.  In 6 months you will
probably only care about "debugging on or off" as the majority of the
messages only help you out when developing the driver, right?

So maybe par down some of the messages, or just live with seeing them
all, it will be easier in the end.

thanks,

grg k-h

  reply	other threads:[~2010-03-16 21:39 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-09 17:52 [PATCH 0/2] small xhci cleanups Alex Chiang
2010-03-09 17:52 ` [PATCH 1/2] USB: xhci: rename driver to xhci_hcd Alex Chiang
2010-03-16 19:03   ` Greg KH
2010-03-09 17:52 ` [PATCH 2/2] USB: xhci: move all debug code under CONFIG_XHCI_HCD_DEBUGGING Alex Chiang
2010-03-09 18:14 ` [PATCH 0/2] small xhci cleanups Greg KH
2010-03-09 18:32   ` Alex Chiang
2010-03-09 18:47     ` Greg KH
2010-03-16 21:24       ` Sarah Sharp
2010-03-16 21:40         ` Greg KH [this message]
2010-03-18 21:33           ` Sarah Sharp
2010-03-18 21:50             ` Roland Dreier
2010-03-18 22:19             ` Greg KH
2010-03-18 22:30               ` Roland Dreier
2010-03-18 22:54               ` Sarah Sharp
  -- strict thread matches above, loose matches on Subject: below --
2010-03-16 20:48 [PATCH v2] USB: xhci: rename driver to xhci_hcd Alex Chiang
2010-03-16 21:09 ` Sarah Sharp
2010-03-17  2:22 ` Crane Cai
2010-03-17  4:30   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100316214014.GA8839@kroah.com \
    --to=greg@kroah.com \
    --cc=achiang@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sarah.a.sharp@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.