From: "Michael S. Tsirkin" <mst@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: amit.shah@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com
Subject: [Qemu-devel] Re: [PATCHv5 11/11] virtio-net: vhost net support
Date: Wed, 17 Mar 2010 12:40:28 +0200 [thread overview]
Message-ID: <20100317104028.GA10425@redhat.com> (raw)
In-Reply-To: <m3bpeop00g.fsf@trasno.mitica>
On Tue, Mar 16, 2010 at 07:57:51PM +0100, Juan Quintela wrote:
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
> > This connects virtio-net to vhost net backend.
> > The code is structured in a way analogous to what we have with vnet
> > header capability in tap.
> >
> > We start/stop backend on driver start/stop as
> > well as on save and vm start (for migration).
> >
>
> > + uint8_t vhost_started;
>
>
> I didn't noticed the 1st time. vhost_started looks like a bool :p
>
> Later, Juan.
Yes. I have no idea why, but the surrounding code has a lot of flags
all of which are uint8_t, so I followed suit.
--
MST
next prev parent reply other threads:[~2010-03-17 10:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-16 17:10 [Qemu-devel] [PATCHv5 00/11] vhost-net: upstream integration Michael S. Tsirkin
2010-03-16 17:10 ` [Qemu-devel] [PATCHv5 01/11] tap: add interface to get device fd Michael S. Tsirkin
2010-03-16 17:10 ` [Qemu-devel] [PATCHv5 02/11] kvm: add API to set ioeventfd Michael S. Tsirkin
2010-03-16 17:10 ` [Qemu-devel] [PATCHv5 03/11] notifier: event notifier implementation Michael S. Tsirkin
2010-03-16 17:10 ` [Qemu-devel] [PATCHv5 04/11] virtio: notifier support + APIs for queue fields Michael S. Tsirkin
2010-03-17 4:14 ` [Qemu-devel] " Amit Shah
2010-03-17 10:48 ` Michael S. Tsirkin
2010-03-16 17:11 ` [Qemu-devel] [PATCHv5 05/11] virtio: add set_status callback Michael S. Tsirkin
2010-03-16 17:11 ` [Qemu-devel] [PATCHv5 06/11] virtio: move typedef to qemu-common Michael S. Tsirkin
2010-03-16 17:11 ` [Qemu-devel] [PATCHv5 07/11] virtio-pci: fill in notifier support Michael S. Tsirkin
2010-03-16 17:11 ` [Qemu-devel] [PATCHv5 08/11] vhost: vhost net support Michael S. Tsirkin
2010-03-16 18:56 ` [Qemu-devel] " Juan Quintela
2010-03-16 17:11 ` [Qemu-devel] [PATCHv5 09/11] tap: add vhost/vhostfd options Michael S. Tsirkin
2010-03-16 17:11 ` [Qemu-devel] [PATCHv5 10/11] tap: add API to retrieve vhost net header Michael S. Tsirkin
2010-03-16 17:11 ` [Qemu-devel] [PATCHv5 11/11] virtio-net: vhost net support Michael S. Tsirkin
2010-03-16 18:57 ` [Qemu-devel] " Juan Quintela
2010-03-17 10:40 ` Michael S. Tsirkin [this message]
2010-03-16 18:58 ` [Qemu-devel] Re: [PATCHv5 00/11] vhost-net: upstream integration Juan Quintela
2010-03-17 4:14 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100317104028.GA10425@redhat.com \
--to=mst@redhat.com \
--cc=amit.shah@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.