From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Brook Subject: Re: [Qemu-devel] Re: >2 serial ports? Date: Wed, 17 Mar 2010 11:18:09 +0000 Message-ID: <201003171118.09873.paul@codesourcery.com> References: <4BA094FE.6020109@msgid.tls.msk.ru> <4BA09E41.7000300@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Cc: Gerd Hoffmann , Michael Tokarev , KVM list To: qemu-devel@nongnu.org Return-path: Received: from mail.codesourcery.com ([38.113.113.100]:43742 "EHLO mail.codesourcery.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754329Ab0CQLSa (ORCPT ); Wed, 17 Mar 2010 07:18:30 -0400 In-Reply-To: <4BA09E41.7000300@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: > Oh, well, yes, I remember. qemu is more strict on ISA irq sharing now. > A bit too strict. > > /me goes dig out a old patch which never made it upstream for some > reason I forgot. Attached. This is wrong. Two devices should never be manipulating the same qemu_irq object. If you want multiple devices connected to the same IRQ then you need an explicit multiplexer. e.g. arm_timer.c:sp804_set_irq. Paul From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NrrPV-00061M-KQ for qemu-devel@nongnu.org; Wed, 17 Mar 2010 07:27:37 -0400 Received: from [199.232.76.173] (port=35402 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NrrPT-0005xX-Bz for qemu-devel@nongnu.org; Wed, 17 Mar 2010 07:27:35 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NrrGh-0001rQ-Ga for qemu-devel@nongnu.org; Wed, 17 Mar 2010 07:18:31 -0400 Received: from mx20.gnu.org ([199.232.41.8]:1941) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NrrGh-0001rM-78 for qemu-devel@nongnu.org; Wed, 17 Mar 2010 07:18:31 -0400 Received: from mail.codesourcery.com ([38.113.113.100]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NrrGg-0006vI-FW for qemu-devel@nongnu.org; Wed, 17 Mar 2010 07:18:30 -0400 From: Paul Brook Subject: Re: [Qemu-devel] Re: >2 serial ports? Date: Wed, 17 Mar 2010 11:18:09 +0000 References: <4BA094FE.6020109@msgid.tls.msk.ru> <4BA09E41.7000300@redhat.com> In-Reply-To: <4BA09E41.7000300@redhat.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201003171118.09873.paul@codesourcery.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Michael Tokarev , Gerd Hoffmann , KVM list > Oh, well, yes, I remember. qemu is more strict on ISA irq sharing now. > A bit too strict. > > /me goes dig out a old patch which never made it upstream for some > reason I forgot. Attached. This is wrong. Two devices should never be manipulating the same qemu_irq object. If you want multiple devices connected to the same IRQ then you need an explicit multiplexer. e.g. arm_timer.c:sp804_set_irq. Paul