All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: Wu Zhangjin <wuzhangjin@gmail.com>
Cc: linux-mips@linux-mips.org,
	Shinya Kuribayashi <shinya.kuribayashi@necel.com>,
	Zhang Le <r0bertz@gentoo.org>, Wu Zhangjin <wuzj@lemote.com>
Subject: Re: [PATCH v3 2/3] Loongson-2F: Enable fixups of binutils 2.20.1
Date: Wed, 17 Mar 2010 14:52:23 +0100	[thread overview]
Message-ID: <20100317135223.GA4554@linux-mips.org> (raw)
In-Reply-To: <ecc51ee134ab84c95b6b02534544df3731bb9562.1268453720.git.wuzhangjin@gmail.com>

On Sat, Mar 13, 2010 at 12:34:16PM +0800, Wu Zhangjin wrote:

> diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> index 2f2eac2..5ae342e 100644
> --- a/arch/mips/Makefile
> +++ b/arch/mips/Makefile
> @@ -135,7 +135,9 @@ cflags-$(CONFIG_CPU_LOONGSON2)	+= -Wa,--trap
>  cflags-$(CONFIG_CPU_LOONGSON2E) += \
>  	$(call cc-option,-march=loongson2e,-march=r4600)
>  cflags-$(CONFIG_CPU_LOONGSON2F) += \
> -	$(call cc-option,-march=loongson2f,-march=r4600)
> +	$(call cc-option,-march=loongson2f,-march=r4600) \
> +	$(call as-option,-Wa$(comma)-mfix-loongson2f-nop,) \
> +	$(call as-option,-Wa$(comma)-mfix-loongson2f-jump,)

Shouldn't these options be used unconditionally?  It seems a kernel build
should rather fail than a possibly unreliable kernel be built - possibly
even without the user noticing the problem.

  Ralf

  reply	other threads:[~2010-03-17 13:52 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-13  4:34 [PATCH v3 0/3] Workaround the Out-of-order Issue of Loongson-2F Wu Zhangjin
2010-03-13  4:34 ` [PATCH v3 1/3] Loongson-2F: Flush the branch target history such as BTB and RAS Wu Zhangjin
2010-03-17 15:11   ` Ralf Baechle
2010-04-02 14:54   ` Andreas Barth
2010-04-03  1:42     ` Wu Zhangjin
2010-04-06 19:10       ` Andreas Barth
2010-04-07  7:30         ` Wu Zhangjin
2010-04-10  8:10           ` Andreas Barth
2010-04-12  3:33             ` Wu Zhangjin
2010-04-03  1:53     ` Zhang Le
2010-04-03  3:11       ` Andreas Barth
2010-03-13  4:34 ` [PATCH v3 2/3] Loongson-2F: Enable fixups of binutils 2.20.1 Wu Zhangjin
2010-03-17 13:52   ` Ralf Baechle [this message]
2010-03-27 16:29     ` Zhang Le
2010-03-27 17:20       ` Zhang Le
2010-03-27 23:17         ` zhangfx
2010-04-07 13:02     ` Wu Zhangjin
2010-03-13  4:34 ` [PATCH v3 3/3] Loongson-2F: Fixup of problems introduced by -mfix-loongson2f-jump " Wu Zhangjin
2010-03-17 15:02   ` Ralf Baechle
2010-03-27 17:13     ` Zhang Le
2010-04-07 12:57     ` Wu Zhangjin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100317135223.GA4554@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=linux-mips@linux-mips.org \
    --cc=r0bertz@gentoo.org \
    --cc=shinya.kuribayashi@necel.com \
    --cc=wuzhangjin@gmail.com \
    --cc=wuzj@lemote.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.