From: Dan Carpenter <error27@gmail.com>
To: Roland Dreier <rdreier@cisco.com>
Cc: Jiri Slaby <jslaby@suse.cz>,
linux-kernel@vger.kernel.org, jirislaby@gmail.com,
Or Gerlitz <ogerlitz@voltaire.com>
Subject: Re: [PATCH 1/1] infiniband: ulp/iser, fix error retval in iser_create_ib_conn_res
Date: Wed, 17 Mar 2010 18:11:22 +0300 [thread overview]
Message-ID: <20100317151122.GF5331@bicker> (raw)
In-Reply-To: <ada634v9644.fsf@roland-alpha.cisco.com>
On Tue, Mar 16, 2010 at 04:52:43PM -0700, Roland Dreier wrote:
> > ib_conn->login_buf = kmalloc(ISER_RX_LOGIN_SIZE, GFP_KERNEL);
> > if (!ib_conn->login_buf) {
> > - goto alloc_err;
> > ret = -ENOMEM;
> > + goto alloc_err;
> > }
>
> This looks like a valid fix but it's the same part of the code that Dan
> found more extensive bugs in. Or, can I assume you'll sort this out and
> make sure a final patch is sorted out?
>
My patch is the one to take. It addresses this problem here and fixes
some double frees.
http://marc.info/?l=linux-rdma&m=126872745710910&w=2
Sorry about that Jiri. Btw. Julia Lawall, Daren Jenkins and I normally CC
kernel-janitors for static checker patches.
regards,
dan carpenter
> Thanks,
> Roland
> --
> Roland Dreier <rolandd@cisco.com>
> For corporate legal information go to:
> http://www.cisco.com/web/about/doing_business/legal/cri/index.html
next prev parent reply other threads:[~2010-03-17 15:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-16 14:49 [PATCH 1/1] infiniband: ulp/iser, fix error retval in iser_create_ib_conn_res Jiri Slaby
2010-03-16 23:52 ` Roland Dreier
2010-03-17 15:11 ` Dan Carpenter [this message]
2010-03-31 21:06 ` Roland Dreier
2010-04-01 15:38 ` Dan Carpenter
2010-04-02 11:27 ` [patch v3] " Dan Carpenter
2010-05-05 18:09 ` Roland Dreier
2010-05-06 13:22 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100317151122.GF5331@bicker \
--to=error27@gmail.com \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=ogerlitz@voltaire.com \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.