diff for duplicates of <20100317155140.GG18243@nokia.com> diff --git a/a/1.txt b/N1/1.txt index b77198f..6560bd8 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -45,7 +45,7 @@ On Wed, Mar 17, 2010 at 02:50:45PM +0100, Valkeinen Tomi (Nokia-D/Helsinki) wrot > > + void __iomem *data_start_v; > > + int offset; > > + -> > + if (ofbi->rotation_type = OMAP_DSS_ROT_VRFB) { +> > + if (ofbi->rotation_type == OMAP_DSS_ROT_VRFB) { > > + data_start_p = omapfb_get_region_rot_paddr(ofbi, rotation); > > + data_start_v = NULL; > > + } else { @@ -53,7 +53,7 @@ On Wed, Mar 17, 2010 at 02:50:45PM +0100, Valkeinen Tomi (Nokia-D/Helsinki) wrot > > + data_start_v = omapfb_get_region_vaddr(ofbi); > > + } > > + -> > + if (ofbi->rotation_type = OMAP_DSS_ROT_VRFB) +> > + if (ofbi->rotation_type == OMAP_DSS_ROT_VRFB) > > + offset = calc_rotation_offset_vrfb(var, fix, rotation); > > + else > > + offset = calc_rotation_offset_dma(var, fix, rotation); @@ -94,7 +94,7 @@ On Wed, Mar 17, 2010 at 02:50:45PM +0100, Valkeinen Tomi (Nokia-D/Helsinki) wrot > > } > > > > - -> > - if (ofbi->rotation_type = OMAP_DSS_ROT_VRFB) { +> > - if (ofbi->rotation_type == OMAP_DSS_ROT_VRFB) { > > - data_start_p = omapfb_get_region_rot_paddr(ofbi, rotation); > > - data_start_v = NULL; > > - } else { @@ -102,7 +102,7 @@ On Wed, Mar 17, 2010 at 02:50:45PM +0100, Valkeinen Tomi (Nokia-D/Helsinki) wrot > > - data_start_v = omapfb_get_region_vaddr(ofbi); > > - } > > - -> > - if (ofbi->rotation_type = OMAP_DSS_ROT_VRFB) +> > - if (ofbi->rotation_type == OMAP_DSS_ROT_VRFB) > > - offset = calc_rotation_offset_vrfb(var, fix, rotation); > > - else > > - offset = calc_rotation_offset_dma(var, fix, rotation); @@ -144,7 +144,7 @@ have it in a separate function. I'll split the patch up. > > + int r; > > > > ovl->get_overlay_info(ovl, &info); -> > + if (info.enabled = enable) +> > + if (info.enabled == enable) > > + return 0; > > info.enabled = enable; > > - return ovl->set_overlay_info(ovl, &info); @@ -156,7 +156,7 @@ have it in a separate function. I'll split the patch up. > > +} > > There are perhaps more changes here than needed. int r is not needed, -> and the last lines do not need to be changed. And is if (info.enabled = +> and the last lines do not need to be changed. And is if (info.enabled == > enable) required by this patch, or is it just optimization? If > optimization, it could be in separate patch. @@ -184,3 +184,7 @@ brain skipped a beat there and I forgot to add the 0s. Will fix. -- Ville Syrjälä +-- +To unsubscribe from this list: send the line "unsubscribe linux-omap" in +the body of a message to majordomo@vger.kernel.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index ea71a30..ec2c653 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,8 +1,8 @@ "ref\01267795582-21004-1-git-send-email-ville.syrjala@nokia.com\0" "ref\01268833845.2417.274.camel@tubuntu.research.nokia.com\0" "From\0Ville Syrj\303\244l\303\244 <ville.syrjala@nokia.com>\0" - "Subject\0Re: [PATCH v3 1/4] DSS2: OMAPFB: Add support for switching memory\0" - "Date\0Wed, 17 Mar 2010 15:51:40 +0000\0" + "Subject\0Re: [PATCH v3 1/4] DSS2: OMAPFB: Add support for switching memory regions\0" + "Date\0Wed, 17 Mar 2010 17:51:40 +0200\0" "To\0Valkeinen Tomi (Nokia-D/Helsinki) <Tomi.Valkeinen@nokia.com>\0" "Cc\0linux-fbdev@vger.kernel.org <linux-fbdev@vger.kernel.org>" " linux-omap@vger.kernel.org <linux-omap@vger.kernel.org>\0" @@ -55,7 +55,7 @@ "> > + void __iomem *data_start_v;\n" "> > + int offset;\n" "> > +\n" - "> > + if (ofbi->rotation_type = OMAP_DSS_ROT_VRFB) {\n" + "> > + if (ofbi->rotation_type == OMAP_DSS_ROT_VRFB) {\n" "> > + data_start_p = omapfb_get_region_rot_paddr(ofbi, rotation);\n" "> > + data_start_v = NULL;\n" "> > + } else {\n" @@ -63,7 +63,7 @@ "> > + data_start_v = omapfb_get_region_vaddr(ofbi);\n" "> > + }\n" "> > +\n" - "> > + if (ofbi->rotation_type = OMAP_DSS_ROT_VRFB)\n" + "> > + if (ofbi->rotation_type == OMAP_DSS_ROT_VRFB)\n" "> > + offset = calc_rotation_offset_vrfb(var, fix, rotation);\n" "> > + else\n" "> > + offset = calc_rotation_offset_dma(var, fix, rotation);\n" @@ -104,7 +104,7 @@ "> > }\n" "> > \n" "> > -\n" - "> > - if (ofbi->rotation_type = OMAP_DSS_ROT_VRFB) {\n" + "> > - if (ofbi->rotation_type == OMAP_DSS_ROT_VRFB) {\n" "> > - data_start_p = omapfb_get_region_rot_paddr(ofbi, rotation);\n" "> > - data_start_v = NULL;\n" "> > - } else {\n" @@ -112,7 +112,7 @@ "> > - data_start_v = omapfb_get_region_vaddr(ofbi);\n" "> > - }\n" "> > -\n" - "> > - if (ofbi->rotation_type = OMAP_DSS_ROT_VRFB)\n" + "> > - if (ofbi->rotation_type == OMAP_DSS_ROT_VRFB)\n" "> > - offset = calc_rotation_offset_vrfb(var, fix, rotation);\n" "> > - else\n" "> > - offset = calc_rotation_offset_dma(var, fix, rotation);\n" @@ -154,7 +154,7 @@ "> > + int r;\n" "> > \n" "> > ovl->get_overlay_info(ovl, &info);\n" - "> > + if (info.enabled = enable)\n" + "> > + if (info.enabled == enable)\n" "> > + return 0;\n" "> > info.enabled = enable;\n" "> > - return ovl->set_overlay_info(ovl, &info);\n" @@ -166,7 +166,7 @@ "> > +}\n" "> \n" "> There are perhaps more changes here than needed. int r is not needed,\n" - "> and the last lines do not need to be changed. And is if (info.enabled =\n" + "> and the last lines do not need to be changed. And is if (info.enabled ==\n" "> enable) required by this patch, or is it just optimization? If\n" "> optimization, it could be in separate patch.\n" "\n" @@ -193,6 +193,10 @@ "brain skipped a beat there and I forgot to add the 0s. Will fix.\n" "\n" "-- \n" - "Ville Syrj\303\244l\303\244" + "Ville Syrj\303\244l\303\244\n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe linux-omap\" in\n" + "the body of a message to majordomo@vger.kernel.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -96c75ddf568d198e8c9ebe24410ba7de9a7127cf5ad5f1224c391297c403539d +6ea6a60e2124578aa6e7e86baba5358031fda0fc37ec57b6891e7a7a60c5c3bd
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.