From: Felipe Balbi <me@felipebalbi.com>
To: Dmitry Kasatkin <dmitry.kasatkin@nokia.com>
Cc: "me@felipebalbi.com" <me@felipebalbi.com>, linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/2] sec: omap sha1 & md5 driver
Date: Thu, 18 Mar 2010 17:36:31 +0200 [thread overview]
Message-ID: <20100318153631.GA3877@gandalf> (raw)
In-Reply-To: <4BA23378.8010100@nokia.com>
Hi,
first of all you shouldn't top-post.
On Thu, Mar 18, 2010 at 04:06:48PM +0200, Dmitry Kasatkin wrote:
> omap_sha1_md5_init() only able to get global dd
> no other choice.
>
> so what is the point to have it as ctx->dd.
the point of not having to global variables is that the driver should
work if with multiples instances of the HW. Besides omap_sha1_md5_init()
is a static function for your driver to use only so you can change that
prototype as much as you want.
> convinced?
no. You should fix the driver before sending it to the public.
--
balbi
next prev parent reply other threads:[~2010-03-18 15:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-17 13:12 [PATCH 0/2] crypto: omap-sha1-md5: OMAP3 SHA1 & MD5 driver Dmitry Kasatkin
2010-03-17 13:12 ` [PATCH 1/2] sec: omap sha1 & md5 driver Dmitry Kasatkin
2010-03-17 17:08 ` Felipe Balbi
2010-03-17 20:49 ` Tony Lindgren
[not found] ` <4BA23378.8010100@nokia.com>
2010-03-18 15:36 ` Felipe Balbi [this message]
2010-03-17 13:12 ` [PATCH 2/2] sec: Makefile/Kconfig update for omap sha1 " Dmitry Kasatkin
2010-03-23 11:32 ` [PATCH 0/2] crypto: omap-sha1-md5: OMAP3 SHA1 & MD5 driver Herbert Xu
2010-03-24 7:31 ` Dmitry Kasatkin
2010-03-24 14:51 ` Dmitry Kasatkin
2010-04-08 14:07 ` Herbert Xu
2010-04-08 14:04 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100318153631.GA3877@gandalf \
--to=me@felipebalbi.com \
--cc=dmitry.kasatkin@nokia.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.