From: Christoph Hellwig <hch@infradead.org>
To: Jeff Layton <jlayton@redhat.com>
Cc: bfields@fieldses.org, linux-nfs@vger.kernel.org, nfsv4@linux-nfs.org
Subject: Re: [PATCH] nfsd: no need to open the file on a COMMIT call
Date: Thu, 18 Mar 2010 17:13:06 -0400 [thread overview]
Message-ID: <20100318211306.GA30287@infradead.org> (raw)
In-Reply-To: <1268940887-8556-1-git-send-email-jlayton@redhat.com>
On Thu, Mar 18, 2010 at 03:34:47PM -0400, Jeff Layton wrote:
> There's no need to call nfsd_open when a COMMIT call comes in over the
> wire. It doesn't really buy us anything to pass a filp into
> vfs_fsync_range.
Yes, it does. Having the braindead calling convention with a possible
NULL file pointer is a real pain for all lower levels, and I have
patches ready to remove the last occurance of that, so please do not
introduce a new one.
prev parent reply other threads:[~2010-03-18 21:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-18 19:34 [PATCH] nfsd: no need to open the file on a COMMIT call Jeff Layton
2010-03-18 21:13 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100318211306.GA30287@infradead.org \
--to=hch@infradead.org \
--cc=bfields@fieldses.org \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=nfsv4@linux-nfs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.