From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PPC: Skip over OF_DT_NOP when unflattening the device tree
Date: Fri, 19 Mar 2010 00:06:21 -0600 [thread overview]
Message-ID: <20100319060621.GC28042@obsidianresearch.com> (raw)
In-Reply-To: <1268977838.8599.53.camel@pasglop>
On Fri, Mar 19, 2010 at 04:50:38PM +1100, Benjamin Herrenschmidt wrote:
> On Tue, 2010-03-09 at 12:30 -0700, Jason Gunthorpe wrote:
> > NOPs within the property section are skipped, but NOPs between
> > OF_DT_END_NODE and OF_DT_BEGIN_NODE were not. My firmware NOPs out
> > entire nodes depending on various environment parameters.
> >
> > of_scan_flat_dt already handles NOP more generally..
>
> Good catch, though that code has now moved over to drivers/of
> and is a bit different. Grant is going to fix it up though.
Ah, I based the patch off 2.6.33..
Grant: let me know if you need some help/testing, nice to run into you
again.
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
Grant Likely <grant.likely@secretlab.ca>
Subject: Re: [PATCH] PPC: Skip over OF_DT_NOP when unflattening the device tree
Date: Fri, 19 Mar 2010 00:06:21 -0600 [thread overview]
Message-ID: <20100319060621.GC28042@obsidianresearch.com> (raw)
In-Reply-To: <1268977838.8599.53.camel@pasglop>
On Fri, Mar 19, 2010 at 04:50:38PM +1100, Benjamin Herrenschmidt wrote:
> On Tue, 2010-03-09 at 12:30 -0700, Jason Gunthorpe wrote:
> > NOPs within the property section are skipped, but NOPs between
> > OF_DT_END_NODE and OF_DT_BEGIN_NODE were not. My firmware NOPs out
> > entire nodes depending on various environment parameters.
> >
> > of_scan_flat_dt already handles NOP more generally..
>
> Good catch, though that code has now moved over to drivers/of
> and is a bit different. Grant is going to fix it up though.
Ah, I based the patch off 2.6.33..
Grant: let me know if you need some help/testing, nice to run into you
again.
Jason
next prev parent reply other threads:[~2010-03-19 6:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-09 19:30 [PATCH] PPC: Skip over OF_DT_NOP when unflattening the device tree Jason Gunthorpe
2010-03-19 5:50 ` Benjamin Herrenschmidt
2010-03-19 5:50 ` Benjamin Herrenschmidt
2010-03-19 6:06 ` Jason Gunthorpe [this message]
2010-03-19 6:06 ` Jason Gunthorpe
2010-03-19 6:18 ` Grant Likely
2010-03-19 6:18 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100319060621.GC28042@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.