From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 05/05] dmaengine: shdma: Enable on SH-Mobile ARM
Date: Fri, 19 Mar 2010 08:15:57 +0000 [thread overview]
Message-ID: <20100319081557.GC10003@linux-sh.org> (raw)
In-Reply-To: <20100319044719.17051.57155.sendpatchset@t400s>
On Fri, Mar 19, 2010 at 05:15:42PM +0900, Magnus Damm wrote:
> Hey Guennadi,
>
> On Fri, Mar 19, 2010 at 4:24 PM, Guennadi Liakhovetski
> <g.liakhovetski@gmx.de> wrote:
> > On Fri, 19 Mar 2010, Magnus Damm wrote:
> >> --- 0005/include/linux/serial_sci.h
> >> +++ work/include/linux/serial_sci.h ? 2010-03-18 23:38:59.000000000 +0900
> >> @@ -3,7 +3,7 @@
> >>
> >> ?#include <linux/serial_core.h>
> >> ?#ifdef CONFIG_SERIAL_SH_SCI_DMA
> >> -#include <asm/dmaengine.h>
> >> +#include <linux/sh_dma.h>
> >
> > Shouldn't this be done in patch "04/05"?
>
> It could, but nothing requires this change in 04/05. So the final
> point where this is needed is 05/05.
>
The ifdefs are also superfluous at this point, but those can be killed
off with an incremental patch.
next prev parent reply other threads:[~2010-03-19 8:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-19 4:47 [PATCH 05/05] dmaengine: shdma: Enable on SH-Mobile ARM Magnus Damm
2010-03-19 7:24 ` Guennadi Liakhovetski
2010-03-19 8:15 ` Magnus Damm
2010-03-19 8:15 ` Paul Mundt [this message]
2010-04-07 7:34 ` Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100319081557.GC10003@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.