[Qemu-devel] Re: [PATCH 00/11] monitor: New commands netdev_add, netdev_del

[Luiz Capitulino <lcapitulino@redhat.com>]

On Thu, 18 Mar 2010 17:33:07 +0100
Markus Armbruster <armbru@redhat.com> wrote:

 I'm getting the following build error:

"""
qemu-option.o: In function `parse_option_bool':
/home/lcapitulino/src/qmp-unstable/qemu-option.c:179: undefined reference to `qerror_report_internal'
qemu-option.o: In function `parse_option_number':
/home/lcapitulino/src/qmp-unstable/qemu-option.c:196: undefined reference to `qerror_report_internal'
/home/lcapitulino/src/qmp-unstable/qemu-option.c:201: undefined reference to `qerror_report_internal'
qemu-option.o: In function `parse_option_size':
/home/lcapitulino/src/qmp-unstable/qemu-option.c:229: undefined reference to `qerror_report_internal'
/home/lcapitulino/src/qmp-unstable/qemu-option.c:233: undefined reference to `qerror_report_internal'
qemu-option.o:/home/lcapitulino/src/qmp-unstable/qemu-option.c:582: more undefined references to `qerror_report_internal' follow
collect2: ld returned 1 exit status
make: *** [qemu-nbd] Error 1
"""

 Adding a qerror_report_internal() entry in qemu-tool.c fixes it.


> Markus Armbruster (11):
>   error: Put error definitions back in alphabetical order
>   error: New QERR_DUPLICATE_ID
>   error: Convert qemu_opts_create() to QError
>   error: New QERR_INVALID_PARAMETER_VALUE
>   error: Convert qemu_opts_set() to QError
>   error: Drop extra messages after qemu_opts_set() and
>     qemu_opts_parse()
>   error: Use QERR_INVALID_PARAMETER_VALUE instead of
>     QERR_INVALID_PARAMETER
>   error: Convert qemu_opts_validate() to QError
>   error: Convert net_client_init() to QError
>   error: New QERR_DEVICE_IN_USE
>   monitor: New commands netdev_add, netdev_del
> 
>  hw/pci-hotplug.c |    2 -
>  hw/qdev.c        |    2 +-
>  monitor.c        |    6 ++-
>  net.c            |   95 +++++++++++++++++++++++++++++++++++++++++------------
>  net.h            |    2 +
>  qemu-config.c    |    1 -
>  qemu-monitor.hx  |   30 +++++++++++++++++
>  qemu-option.c    |   24 +++++--------
>  qerror.c         |   20 ++++++++++-
>  qerror.h         |   17 ++++++++--
>  vl.c             |    5 ---
>  11 files changed, 151 insertions(+), 53 deletions(-)
>