From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Albert Herranz <albert_herranz@yahoo.es>
Cc: iommu@lists.linux-foundation.org, linux-usb@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v5 08/10] wii: add mem2 dma mapping ops
Date: Fri, 19 Mar 2010 15:51:14 -0400 [thread overview]
Message-ID: <20100319195114.GD31908@phenom.dumpdata.com> (raw)
In-Reply-To: <1269023546-25534-9-git-send-email-albert_herranz@yahoo.es>
> +/*
> + * The mem2_dma "device".
> + *
> + * This device "owns" a pool of coherent MEM2 memory that can be shared among
> + * several devices requiring MEM2 DMA buffers, instead of dedicating specific
> + * pools for each device.
> + *
> + * A device can use the shared coherent MEM2 memory pool by calling
> + * wii_set_mem2_dma_constraints().
> + *
> + */
> +
> +struct mem2_dma {
> + struct platform_device *pdev;
> +
The space there isn't neccessary.
> + dma_addr_t dma_base;
I think you need only one of them. You don't seem to use 'base'
> + void *base;
> + size_t size;
> +};
next prev parent reply other threads:[~2010-03-19 20:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-19 18:32 [PATCH v5 00/10] wii: add usb 2.0 support Albert Herranz
2010-03-19 18:32 ` [PATCH v5 01/10] swiotbl: add back swiotlb_alloc_boot() Albert Herranz
2010-03-19 18:32 ` [PATCH v5 02/10] swiotlb: make swiotlb_bounce() __weak Albert Herranz
2010-03-19 18:32 ` [PATCH v5 03/10] powerpc: add per-device dma coherent support Albert Herranz
2010-03-19 18:32 ` [PATCH v5 04/10] powerpc: add min_direct_dma_addr Albert Herranz
2010-03-19 18:32 ` [PATCH v5 05/10] USB: refactor unmap_urb_for_dma/map_urb_for_dma Albert Herranz
2010-03-19 18:32 ` [PATCH v5 06/10] USB: add HCD_NO_COHERENT_MEM host controller driver flag Albert Herranz
2010-03-19 18:32 ` [PATCH v5 07/10] wii: have generic dma coherent Albert Herranz
2010-03-19 18:32 ` [PATCH v5 08/10] wii: add mem2 dma mapping ops Albert Herranz
2010-03-19 19:50 ` Konrad Rzeszutek Wilk
2010-03-20 0:59 ` Albert Herranz
2010-03-19 19:51 ` Konrad Rzeszutek Wilk [this message]
2010-03-20 0:58 ` Albert Herranz
2010-03-19 18:32 ` [PATCH v5 09/10] wii: enable swiotlb Albert Herranz
2010-03-19 18:32 ` [PATCH v5 10/10] wii: hollywood ehci controller support Albert Herranz
2010-03-19 19:01 ` [PATCH v5 00/10] wii: add usb 2.0 support Alan Stern
2010-03-19 19:13 ` Albert Herranz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100319195114.GD31908@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=albert_herranz@yahoo.es \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.