From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Nsix2-00052X-GM for mharc-grub-devel@gnu.org; Fri, 19 Mar 2010 16:37:48 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nsiww-00051D-Sx for grub-devel@gnu.org; Fri, 19 Mar 2010 16:37:43 -0400 Received: from [140.186.70.92] (port=49373 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nsiwl-0004so-ED for grub-devel@gnu.org; Fri, 19 Mar 2010 16:37:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nsivo-000087-1S for grub-devel@gnu.org; Fri, 19 Mar 2010 16:36:32 -0400 Received: from mail-fx0-f210.google.com ([209.85.220.210]:64640) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nsivn-00007t-Sx for grub-devel@gnu.org; Fri, 19 Mar 2010 16:36:32 -0400 Received: by fxm2 with SMTP id 2so965516fxm.26 for ; Fri, 19 Mar 2010 13:36:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:received:received :received:date:from:to:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=9YARs1ujRoLefHiuDnL6Gzpv08MVqBHZCAn7ww0cbpM=; b=ibdg6VRNP3aGtXDhAtxnv4VQYi1uCn+fOwzDVTU8TN1om2I3ISEt/YusfKrlmbKrBI 9K93zoAtV+x7JwB9Y4XhGK5DU8CwiRJbvggYdbwfoYh3fXbvHCW5mFfNSM49xubNPC36 giqH/5gvMo7jpiwjyGMFJl7OvNup2d5AOHBZ8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:date:from:to:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=Ifd/B6DYjcmbpr4ao/mMoz/iDsCYQ8nM8fEDBvEpAwAEJZa0r5/0Ts2LgNpFdxhGiS UGDX1jHxI/4mqkpnh/tWk8bgDi4XNOubXKLdacHL7C+spb3OoD/9Pn9FuJ8g6Er5lgmI gp+LgleBL00sxNrdcrynG7YF7GFpvhIBXiAzc= Received: by 10.103.81.39 with SMTP id i39mr2582513mul.28.1269030989248; Fri, 19 Mar 2010 13:36:29 -0700 (PDT) Received: from mail.pina.cat (197.Red-80-32-81.staticIP.rima-tde.net [80.32.81.197]) by mx.google.com with ESMTPS id 23sm8248576mun.7.2010.03.19.13.36.26 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 19 Mar 2010 13:36:27 -0700 (PDT) Sender: Carles Pina i Estany Received: from pinux (cpc2-hari6-0-0-cust86.hari.cable.virginmedia.com [82.45.164.87]) by mail.pina.cat (Postfix) with ESMTPA id 81A12288F3017 for ; Fri, 19 Mar 2010 21:36:24 +0100 (CET) Received: from pinux (localhost.localdomain [127.0.0.1]) by pinux (Postfix) with ESMTP id B0902894F9B for ; Fri, 19 Mar 2010 20:36:23 +0000 (GMT) Received: by pinux (Postfix, from userid 1000) id 6BF43894F9A; Fri, 19 Mar 2010 20:35:23 +0000 (GMT) Date: Fri, 19 Mar 2010 20:35:23 +0000 From: Carles Pina i Estany To: The development of GNU GRUB Message-ID: <20100319203523.GA7679@pina.cat> References: <20100319115008.GV20777@riva.ucam.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100319115008.GV20777@riva.ucam.org> User-Agent: Mutt/1.5.20 (2009-06-14) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] Fix locale installation X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Mar 2010 20:37:44 -0000 Hello, On Mar/19/2010, Colin Watson wrote: > (cpina, if you're reading, I'd particularly appreciate your review.) Here I am > As far as I can see, locale installation is just wrong right now. I cannot test it easily now. I'll comment the new thing forgetting about the old one (doesn't look right) > # Copy gettext files > mkdir -p ${grubdir}/locale/ > -for file in ${grubdir}/locale/*.mo ${pkglibdir}/locale/*.mo; do > - if test -f "$file"; then > - cp -f "$file" ${grubdir}/locale/ > +for dir in ${localedir}/*; do > + if test -f "$dir/LC_MESSAGES/grub.mo"; then > + cp -f "$dir/LC_MESSAGES/grub.mo" "${grubdir}/locale/${dir##*/}.mo" > fi > done (I'll use shell variables in a bit "on my own way") AFAIK the files are in po/$lang.{po,mo}, right? (at least in my system without using another directory for the building, I need to look in the other issue soon) I thought that make install was copying from po/$lang.mo to /usr/share/locale/$lang/LC_MESSAGES/grub.mo, but you are copying already from some structure in $localedir/LC_MESSAGES/grub.mo. What am I missing? It has been a while that I have not done these things, so sorry to be more an "askwer" than "answerer". -- Carles Pina i Estany http://pinux.info