From: Michael Buesch <mb@bu3sch.de>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org,
Larry Finger <Larry.Finger@lwfinger.net>,
stable@kernel.org
Subject: Re: [PATCH] ssb: do not read SPROM if it does not exist
Date: Fri, 19 Mar 2010 20:46:23 +0100 [thread overview]
Message-ID: <201003192046.23194.mb@bu3sch.de> (raw)
In-Reply-To: <201003192041.47211.mb@bu3sch.de>
On Friday 19 March 2010 20:41:47 Michael Buesch wrote:
> > + if (bus->chip_rev >= 31)
>
> This check is wrong.
> You need to check the chipcommon core revision. Not the chip revision.
Actually. All three checks in the patch are wrong. Not just in this place.
--
Greetings, Michael.
next prev parent reply other threads:[~2010-03-19 19:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-18 17:46 RFC: A workaround for BCM43XX devices with no on-board SPROM Larry Finger
2010-03-18 19:31 ` Michael Buesch
2010-03-18 20:20 ` John W. Linville
2010-03-18 20:31 ` Johannes Berg
2010-03-18 21:38 ` Larry Finger
2010-03-19 7:36 ` Michael Buesch
2010-03-18 20:51 ` Nicolas de Pesloüan
2010-03-18 20:53 ` Johannes Berg
2010-03-18 21:10 ` Larry Finger
2010-03-18 21:20 ` Johannes Berg
2010-03-18 21:47 ` Larry Finger
2010-03-19 18:40 ` Kalle Valo
2010-03-19 19:08 ` [PATCH] ssb: do not read SPROM if it does not exist John W. Linville
2010-03-19 19:41 ` Michael Buesch
2010-03-19 19:46 ` Michael Buesch [this message]
2010-03-19 20:21 ` John W. Linville
2010-03-19 20:30 ` Michael Buesch
2010-03-19 20:31 ` John W. Linville
2010-03-19 20:33 ` [PATCH v2] " John W. Linville
2010-03-19 20:41 ` [PATCH v3] " John W. Linville
2010-03-19 21:12 ` Michael Buesch
2010-03-19 22:10 ` John W. Linville
2010-03-19 22:10 ` [PATCH v4] " John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201003192046.23194.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.