All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Mack <daniel@caiaq.de>
To: alsa-devel@alsa-project.org
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Nicolas Pitre <nico@marvell.com>,
	Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ALSA: ASoC: pxa-pcm-lib: initialize DMA channel to -1
Date: Sat, 20 Mar 2010 16:47:15 +0100	[thread overview]
Message-ID: <20100320154715.GD30801@buzzloop.caiaq.de> (raw)
In-Reply-To: <1267324958-25103-1-git-send-email-daniel@caiaq.de>

Any oppinion about this one?

(Sorry for the clock skew - the virtual machine I did this in lives in
 its own world)

On Sun, Feb 28, 2010 at 10:42:38AM +0800, Daniel Mack wrote:
> This fixes a warning ("pxa_free_dma: trying to free channel 0 which is
> already freed") when a device was opened but the hw_params() call
> failed.
> 
> Signed-off-by: Daniel Mack <daniel@caiaq.de>
> Cc: Liam Girdwood <lrg@slimlogic.co.uk>
> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Cc: Nicolas Pitre <nico@marvell.com>
> ---
>  sound/arm/pxa2xx-pcm-lib.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/arm/pxa2xx-pcm-lib.c b/sound/arm/pxa2xx-pcm-lib.c
> index 743ac6a..fd51fa8 100644
> --- a/sound/arm/pxa2xx-pcm-lib.c
> +++ b/sound/arm/pxa2xx-pcm-lib.c
> @@ -205,6 +205,7 @@ int __pxa2xx_pcm_open(struct snd_pcm_substream *substream)
>  	if (!rtd->dma_desc_array)
>  		goto err1;
>  
> +	rtd->dma_ch = -1;
>  	runtime->private_data = rtd;
>  	return 0;
>  
> -- 
> 1.6.3.3
> 

  reply	other threads:[~2010-03-20 15:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-28  2:42 [PATCH] ALSA: ASoC: pxa-pcm-lib: initialize DMA channel to -1 Daniel Mack
2010-03-20 15:47 ` Daniel Mack [this message]
2010-03-20 16:34   ` Mark Brown
2010-03-22  8:55     ` Liam Girdwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100320154715.GD30801@buzzloop.caiaq.de \
    --to=daniel@caiaq.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lrg@slimlogic.co.uk \
    --cc=nico@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.