From: Christoph Hellwig <hch@lst.de>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: haad <haad@netbsd.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] NetBSD qemu block device support
Date: Sat, 20 Mar 2010 17:32:00 +0100 [thread overview]
Message-ID: <20100320163200.GA9159@lst.de> (raw)
In-Reply-To: <f43fc5581003181332n2a3dea2bs85a8e91be4b8beb8@mail.gmail.com>
On Thu, Mar 18, 2010 at 10:32:36PM +0200, Blue Swirl wrote:
> The patch does not apply to current development repository.
>
> There is no description of the change suitable for changelog without
> any editing.
>
> Signed-off-by: line is missing.
>
> The patch combines formatting (whitespace) changes with functional
> changes. The formatting changes seem useless.
>
> The essence of the patch is twofold, It adds NetBSD specific includes
> and NetBSD specific code to raw_getlength(). These look OK, except
> formatting may be a bit off (no space after if) and currently the code
> probably should be surrounded by
> #ifdef DIOCGWEDGEINFO
> #endif
> or just #ifdef __NetBSD__.
Also given the extreme mess that raw_getlength is I would much prefer
to give every new OS it's own copy of it, similar to how we already
handle OpenBSD today.
next prev parent reply other threads:[~2010-03-20 16:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-17 12:59 [Qemu-devel] NetBSD qemu block device support haad
2010-03-18 20:32 ` Blue Swirl
2010-03-20 16:32 ` Christoph Hellwig [this message]
[not found] ` <19FEF06F-E51D-4D44-871B-CE0B2375F2E8@gmail.com>
2010-09-21 14:01 ` haad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100320163200.GA9159@lst.de \
--to=hch@lst.de \
--cc=blauwirbel@gmail.com \
--cc=haad@netbsd.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.