From: Thomas Renninger <trenn@suse.de>
To: "Robert Schöne" <robert.schoene@tu-dresden.de>
Cc: Arjan van de Ven <arjan@linux.intel.com>,
Dave Jones <davej@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
"linux-kernel" <linux-kernel@vger.kernel.org>,
cpufreq <cpufreq@vger.kernel.org>,
x86@kernel.org
Subject: Re: [PATCH] trace power_frequency events on the correct cpu (for Intel x86 CPUs)
Date: Sat, 20 Mar 2010 22:37:56 +0100 [thread overview]
Message-ID: <201003202237.57477.trenn@suse.de> (raw)
In-Reply-To: <1268985679.3395.47.camel@localhost>
> This wrapper would make things easier of course, since one might add the
> same line for every driver
...
It's simply broken and can't be fixed without chaninging the whole concept.
power_frequency_events() must not only pass the cpu, but a cpumask also for
acpi-cpufreq.
If you look at SW_ANY SW_ALL (or similar, I can't look at code right now)
parts, acpi-cpufreq can change the frequency for several cores with one MSR
write.
AFAIK this is for example the recommended way for Dunnington (6 cores).
So the collected data can be totally wrong.
Better remove this before others also start to use it.
It also seem to be (hopefully) a minor feature for timechart, so this should
not hurt that much (yet).
Thomas
next prev parent reply other threads:[~2010-03-20 21:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-12 13:17 [PATCH] trace power_frequency events on the correct cpu (for Intel x86 CPUs) Robert Schöne
2010-03-12 14:52 ` Arjan van de Ven
2010-03-12 15:41 ` Robert Schöne
2010-03-15 10:51 ` Thomas Renninger
2010-03-16 7:13 ` Robert Schöne
2010-03-16 9:57 ` Ingo Molnar
2010-03-16 10:59 ` Thomas Renninger
2010-03-16 14:19 ` Arjan van de Ven
2010-03-16 14:50 ` Thomas Renninger
2010-03-16 16:40 ` Arjan van de Ven
2010-03-17 16:36 ` Thomas Renninger
2010-03-17 16:41 ` Arjan van de Ven
2010-03-18 20:43 ` Thomas Renninger
2010-03-19 8:01 ` Robert Schöne
2010-03-20 21:37 ` Thomas Renninger [this message]
2010-03-22 0:42 ` Arjan van de Ven
2010-03-22 7:04 ` Robert Schöne
2010-03-22 13:57 ` Arjan van de Ven
2010-03-23 16:28 ` Robert Schöne
2010-03-23 16:57 ` Thomas Renninger
2010-03-23 16:58 ` Arjan van de Ven
2010-03-24 7:07 ` Robert Schöne
2010-03-30 5:46 ` Robert Schöne
2010-03-30 8:56 ` Thomas Renninger
2010-03-31 6:40 ` Robert Schöne
2010-04-12 6:53 ` Robert Schöne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201003202237.57477.trenn@suse.de \
--to=trenn@suse.de \
--cc=arjan@linux.intel.com \
--cc=cpufreq@vger.kernel.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=robert.schoene@tu-dresden.de \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.