From: Oleg Nesterov <oleg@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Balbir Singh <balbir@linux.vnet.ibm.com>,
Roland McGrath <roland@redhat.com>,
Veaceslav Falico <vfalico@redhat.com>,
Stanislaw Gruszka <sgruszka@redhat.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH -mm 2/3] kill the obsolete thread_group_cputime_free() and taskstats_tgid_init() helpers
Date: Sun, 21 Mar 2010 19:47:54 +0100 [thread overview]
Message-ID: <20100321184754.GA29075@redhat.com> (raw)
Trivial, but a separate patch for paranoid reasons.
- Kill the empty thread_group_cputime_free() helper. It was needed
to free the per-cpu data which we no longer have.
- Kill taskstats_tgid_init(), unneeded since
"copy_signal() cleanup: use zalloc and remove initializations"
a56704ef6b0c5796c9ff38cc78aa232dfb9644d7
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
include/linux/sched.h | 4 ----
include/linux/taskstats_kern.h | 7 -------
kernel/fork.c | 1 -
3 files changed, 12 deletions(-)
--- 34-rc1/include/linux/sched.h~12_KILL_DEAD_HELPERS 2010-03-21 18:31:47.000000000 +0100
+++ 34-rc1/include/linux/sched.h 2010-03-21 18:35:01.000000000 +0100
@@ -2396,10 +2396,6 @@ static inline void thread_group_cputime_
sig->cputimer.running = 0;
}
-static inline void thread_group_cputime_free(struct signal_struct *sig)
-{
-}
-
/*
* Reevaluate whether the task has signals pending delivery.
* Wake the task if so.
--- 34-rc1/include/linux/taskstats_kern.h~12_KILL_DEAD_HELPERS 2010-03-21 18:31:47.000000000 +0100
+++ 34-rc1/include/linux/taskstats_kern.h 2010-03-21 18:35:01.000000000 +0100
@@ -14,11 +14,6 @@
extern struct kmem_cache *taskstats_cache;
extern struct mutex taskstats_exit_mutex;
-static inline void taskstats_tgid_init(struct signal_struct *sig)
-{
- sig->stats = NULL;
-}
-
static inline void taskstats_tgid_free(struct signal_struct *sig)
{
if (sig->stats)
@@ -30,8 +25,6 @@ extern void taskstats_init_early(void);
#else
static inline void taskstats_exit(struct task_struct *tsk, int group_dead)
{}
-static inline void taskstats_tgid_init(struct signal_struct *sig)
-{}
static inline void taskstats_tgid_free(struct signal_struct *sig)
{}
static inline void taskstats_init_early(void)
--- 34-rc1/kernel/fork.c~12_KILL_DEAD_HELPERS 2010-03-21 18:34:02.000000000 +0100
+++ 34-rc1/kernel/fork.c 2010-03-21 18:35:01.000000000 +0100
@@ -160,7 +160,6 @@ EXPORT_SYMBOL(free_task);
static inline void free_signal_struct(struct signal_struct *sig)
{
- thread_group_cputime_free(sig);
kmem_cache_free(signal_cachep, sig);
}
reply other threads:[~2010-03-21 18:49 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100321184754.GA29075@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
--cc=sgruszka@redhat.com \
--cc=vfalico@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.