From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Date: Mon, 22 Mar 2010 10:20:13 +0000 Subject: Re: [lm-sensors] [PATCH 1/2] Hwmon: f71882fg: fixed braces coding Message-Id: <20100322112013.62f962e3@hyperion.delvare> List-Id: References: <1269185834-10266-1-git-send-email-me@mortis.eu> <4BA738CE.8000901@redhat.com> In-Reply-To: <4BA738CE.8000901@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Hans de Goede Cc: Giel van Schijndel , Jonathan Cameron , lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org On Mon, 22 Mar 2010 10:30:54 +0100, Hans de Goede wrote: > Ack. > > Acked-by: Hans de Goede Applied, thanks. > On 03/21/2010 04:37 PM, Giel van Schijndel wrote: > > Fixed several coding style issues. > > > > Signed-off-by: Giel van Schijndel > > --- > > drivers/hwmon/f71882fg.c | 11 +++++------ > > 1 files changed, 5 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/hwmon/f71882fg.c b/drivers/hwmon/f71882fg.c > > index a95fa42..21bc661 100644 > > --- a/drivers/hwmon/f71882fg.c > > +++ b/drivers/hwmon/f71882fg.c > > @@ -866,11 +866,11 @@ static int superio_inw(int base, int reg) > > static inline void superio_enter(int base) > > { > > /* according to the datasheet the key must be send twice! */ > > - outb( SIO_UNLOCK_KEY, base); > > - outb( SIO_UNLOCK_KEY, base); > > + outb(SIO_UNLOCK_KEY, base); > > + outb(SIO_UNLOCK_KEY, base); > > } > > > > -static inline void superio_select( int base, int ld) > > +static inline void superio_select(int base, int ld) > > { > > outb(SIO_REG_LDSEL, base); > > outb(ld, base + 1); > > @@ -945,7 +945,7 @@ static struct f71882fg_data *f71882fg_update_device(struct device *dev) > > mutex_lock(&data->update_lock); > > > > /* Update once every 60 seconds */ > > - if ( time_after(jiffies, data->last_limits + 60 * HZ ) || > > + if (time_after(jiffies, data->last_limits + 60 * HZ) || > > !data->valid) { > > if (data->type = f71882fg || data->type = f71889fg) { > > data->in1_max > > @@ -2151,8 +2151,7 @@ static int __init f71882fg_find(int sioaddr, unsigned short *address, > > } > > > > *address = superio_inw(sioaddr, SIO_REG_ADDR); > > - if (*address = 0) > > - { > > + if (*address = 0) { > > printk(KERN_WARNING DRVNAME ": Base address not set\n"); > > goto exit; > > } -- Jean Delvare _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754066Ab0CVKUW (ORCPT ); Mon, 22 Mar 2010 06:20:22 -0400 Received: from poutre.nerim.net ([62.4.16.124]:56925 "EHLO poutre.nerim.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753012Ab0CVKUU (ORCPT ); Mon, 22 Mar 2010 06:20:20 -0400 Date: Mon, 22 Mar 2010 11:20:13 +0100 From: Jean Delvare To: Hans de Goede Cc: Giel van Schijndel , Jonathan Cameron , lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] Hwmon: f71882fg: fixed braces coding style issues Message-ID: <20100322112013.62f962e3@hyperion.delvare> In-Reply-To: <4BA738CE.8000901@redhat.com> References: <1269185834-10266-1-git-send-email-me@mortis.eu> <4BA738CE.8000901@redhat.com> X-Mailer: Claws Mail 3.5.0 (GTK+ 2.14.4; i586-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 Mar 2010 10:30:54 +0100, Hans de Goede wrote: > Ack. > > Acked-by: Hans de Goede Applied, thanks. > On 03/21/2010 04:37 PM, Giel van Schijndel wrote: > > Fixed several coding style issues. > > > > Signed-off-by: Giel van Schijndel > > --- > > drivers/hwmon/f71882fg.c | 11 +++++------ > > 1 files changed, 5 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/hwmon/f71882fg.c b/drivers/hwmon/f71882fg.c > > index a95fa42..21bc661 100644 > > --- a/drivers/hwmon/f71882fg.c > > +++ b/drivers/hwmon/f71882fg.c > > @@ -866,11 +866,11 @@ static int superio_inw(int base, int reg) > > static inline void superio_enter(int base) > > { > > /* according to the datasheet the key must be send twice! */ > > - outb( SIO_UNLOCK_KEY, base); > > - outb( SIO_UNLOCK_KEY, base); > > + outb(SIO_UNLOCK_KEY, base); > > + outb(SIO_UNLOCK_KEY, base); > > } > > > > -static inline void superio_select( int base, int ld) > > +static inline void superio_select(int base, int ld) > > { > > outb(SIO_REG_LDSEL, base); > > outb(ld, base + 1); > > @@ -945,7 +945,7 @@ static struct f71882fg_data *f71882fg_update_device(struct device *dev) > > mutex_lock(&data->update_lock); > > > > /* Update once every 60 seconds */ > > - if ( time_after(jiffies, data->last_limits + 60 * HZ ) || > > + if (time_after(jiffies, data->last_limits + 60 * HZ) || > > !data->valid) { > > if (data->type == f71882fg || data->type == f71889fg) { > > data->in1_max = > > @@ -2151,8 +2151,7 @@ static int __init f71882fg_find(int sioaddr, unsigned short *address, > > } > > > > *address = superio_inw(sioaddr, SIO_REG_ADDR); > > - if (*address == 0) > > - { > > + if (*address == 0) { > > printk(KERN_WARNING DRVNAME ": Base address not set\n"); > > goto exit; > > } -- Jean Delvare