From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org, "Avi Kivity" <avi@redhat.com>,
"Frédéric Weisbecker" <fweisbec@gmail.com>,
"Mike Galbraith" <efault@gmx.de>,
"Peter Zijlstra" <a.p.zijlstra@chello.nl>,
"Paul Mackerras" <paulus@samba.org>
Subject: Re: [PATCH 1/1] perf report: newt callgraphs
Date: Mon, 22 Mar 2010 18:11:47 -0300 [thread overview]
Message-ID: <20100322211147.GQ2873@ghostprotocols.net> (raw)
In-Reply-To: <1269291169-29820-1-git-send-email-acme@infradead.org>
Em Mon, Mar 22, 2010 at 05:52:49PM -0300, Arnaldo Carvalho de Melo escreveu:
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> Starts collapsed, allows annotating by pressing 'A' or 'a' on the symbol, be it
> the top level one or any of the symbols in the chains.
>
> It (ab)uses the only tree widget in newt, that is actually a checkbox tree that
> we use with just one option ('.'), end result is usable but we really need to
> create a custom widget tree so that we can use the data structures we have
> (hist_entry rb_tree + callchain rb_tree + lists), so that we reduce the memory
> footprint by not creating a mirror set of data structures in the
> newtCheckboxTree widget.
>
> Thanks to Frédéric Weisbacker for fixing the orphanage problem in
> 301fde2, without that we were tripping a newt bug (fix already sent to
> newt's maintainer).
For the curious, here is a screenshot:
http://tglx.de/~acme/perf-newt-callgraph.png
- Arnaldo
prev parent reply other threads:[~2010-03-22 21:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-22 20:52 [PATCH 1/1] perf report: newt callgraphs Arnaldo Carvalho de Melo
2010-03-22 21:11 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100322211147.GQ2873@ghostprotocols.net \
--to=acme@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=avi@redhat.com \
--cc=efault@gmx.de \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.