From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/2] sh: Flush ITLB too in PTEAEX's flush_tlb_page()
Date: Tue, 23 Mar 2010 04:39:31 +0000 [thread overview]
Message-ID: <20100323043930.GH13417@linux-sh.org> (raw)
In-Reply-To: <1269201103-28283-1-git-send-email-matt@console-pimps.org>
On Sun, Mar 21, 2010 at 07:51:43PM +0000, Matt Fleming wrote:
> flush_tlb_page() can be used to flush TLB entries that map executable
> pages. Therefore, we need to ensure that the ITLB is also flushed in
> local_flush_tlb_page().
On Sun, Mar 21, 2010 at 07:51:52PM +0000, Matt Fleming wrote:
> Setting the TI in MMUCR causes all the TLB bits in MMUCR to be
> cleared. Unfortunately, the TLB wired bits are also cleared when setting
> the TI bit, causing any wired TLB entries to become unwired.
>
> Use local_flush_tlb_all() which implements TLB flushing in a safer
> manner by using the memory-mapped TLB registers. As each CPU has its own
> PMB the modifications in pmb_init() only affect the local CPU, so only
> flush the local CPU's TLB.
On Mon, Mar 22, 2010 at 10:09:58PM +0000, Matt Fleming wrote:
> set_pmb_entry() is now only used by a function that is wrapped in #ifdef
> CONFIG_PM, so wrap set_pmb_entry() in CONFIG_PM too.
All applied, thanks.
prev parent reply other threads:[~2010-03-23 4:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-21 19:51 [PATCH 1/2] sh: Flush ITLB too in PTEAEX's flush_tlb_page() Matt Fleming
2010-03-23 4:39 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100323043930.GH13417@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.