From: Dan Carpenter <error27@gmail.com>
To: Olimpiu Pascariu <olimpiu.pascariu@gmail.com>,
gregkh@suse.de, mchehab@redhat.com,
palash.bandyopadhyay@conexant.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH 5/5] Staging: cx25821: fix coding style issues in cx25821-medusa-video.c
Date: Tue, 23 Mar 2010 14:06:55 +0300 [thread overview]
Message-ID: <20100323110655.GW21571@bicker> (raw)
In-Reply-To: <20100323110259.GV21571@bicker>
On Tue, Mar 23, 2010 at 02:03:00PM +0300, Dan Carpenter wrote:
> On Mon, Mar 22, 2010 at 10:10:30PM +0200, Olimpiu Pascariu wrote:
> > >From 32591165a537a03f472c68289798044d6eeea2e0 Mon Sep 17 00:00:00 2001
> > From: Olimpiu Pascariu <olimpiu.pascariu@gmail.com>
> > Date: Mon, 22 Mar 2010 22:07:20 +0200
> > Subject: [PATCH 5/5] Staging: cx25821: fix coding style issues in cx25821-medusa-video.c
> > This is a patch to cx25821-medusa-video.c file that fixes up warnings and errors found by the checkpatch.pl tool
> > Signed-off-by: Olimpiu Pascariu <olimpiu.pascariu@gmail.com>
>
> [snip]
>
> > + /*
> > + * clear VPRES_VERT_EN bit, fixes the chroma run away problem
> > + * when the input switching rate < 16 fields
> > + */
> ^^^
> Missing a space here.
>
> Otherwise looks good.
>
> Acked-by: Dan Carpenter <error27@gmail.com>
>
> regard,
> dan carpenter
Oh sorry. I thought this was a new patch. This is fine to go in as is
by me... Maybe hold off for a couple days and see if anyone else has
any comments.
regards,
dan carpenter
next prev parent reply other threads:[~2010-03-23 11:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-21 18:51 [PATCH 5/5] Staging: cx25821: fix coding style issues in cx25821-medusa-video.c Olimpiu Pascariu
2010-03-22 13:35 ` Dan Carpenter
2010-03-22 20:10 ` Olimpiu Pascariu
2010-03-23 11:03 ` Dan Carpenter
2010-03-23 11:06 ` Dan Carpenter [this message]
2010-03-22 20:23 ` Olimpiu Pascariu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100323110655.GW21571@bicker \
--to=error27@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=olimpiu.pascariu@gmail.com \
--cc=palash.bandyopadhyay@conexant.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.