From: Andrew Morton <akpm@linux-foundation.org>
To: Huang Ying <ying.huang@intel.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: Re: [BUGFIX] Fix AES-NI CTR optimization compiling failure with gas 2.16.1
Date: Tue, 23 Mar 2010 14:23:24 -0700 [thread overview]
Message-ID: <20100323142324.a53b20de.akpm@linux-foundation.org> (raw)
In-Reply-To: <1268377307.1640.491.camel@yhuang-dev.sh.intel.com>
On Fri, 12 Mar 2010 15:01:47 +0800
Huang Ying <ying.huang@intel.com> wrote:
> Andrew Morton reported that AES-NI CTR optimization failed to compile
> with gas 2.16.1, the error message is as follow:
>
> arch/x86/crypto/aesni-intel_asm.S: Assembler messages:
> arch/x86/crypto/aesni-intel_asm.S:752: Error: suffix or operands invalid for `movq'
> arch/x86/crypto/aesni-intel_asm.S:753: Error: suffix or operands invalid for `movq'
>
> To fix this, a gas macro is defined to assemble movq with 64bit
> general purpose registers and XMM registers. The macro will generate
> the raw .byte sequence for needed instructions.
>
Still no go.
arch/x86/crypto/aesni-intel_asm.S: Assembler messages:
arch/x86/crypto/aesni-intel_asm.S:752: Error: bad expression
arch/x86/crypto/aesni-intel_asm.S:752: Error: junk at end of line, first unrecognized character is `1'
arch/x86/crypto/aesni-intel_asm.S:753: Error: bad expression
arch/x86/crypto/aesni-intel_asm.S:753: Error: junk at end of line, first unrecognized character is `1'
it doesn't like this:
REG_TYPE movq_r64_xmm_opd1_type \opd1
next prev parent reply other threads:[~2010-03-23 21:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-12 7:01 [BUGFIX] Fix AES-NI CTR optimization compiling failure with gas 2.16.1 Huang Ying
2010-03-12 8:37 ` Avi Kivity
2010-03-12 8:42 ` David Miller
2010-03-12 8:44 ` Avi Kivity
2010-03-12 8:50 ` David Miller
2010-03-12 9:33 ` Avi Kivity
2010-03-13 8:29 ` Herbert Xu
2010-03-23 21:23 ` Andrew Morton [this message]
2010-03-24 6:24 ` Huang Ying
2010-03-24 10:51 ` Andrew Morton
2010-03-24 13:38 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100323142324.a53b20de.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.