Re: [LTP] [BUG] cgroup_fj tests fail to run due to missing cgroup_fj_testcases

[Rishikesh K Rajak <risrajak@linux.vnet.ibm.com>]

On Tue, Mar 23, 2010 at 05:55:27PM +0530, Srinivasa R Chamarthy wrote:
> Hi LTP,
> 
> cgroup_fj tests of controllers is currently failing due to missing file
> cgroup_fj_testcases after compilation. I see that the file cgroup_fj_testcases
> is existing in the source but it is not available in /opt/ltp after
> compilation.
> 
> FAILED COMMAND File: /opt/ltp/output/LTP_RUN_ON-2010_Mar_23-13h_22m_15s.failed
> Running tests.......
> <<<test_start>>>
> tag=cgroup_fj stime=1269346936
> cmdline="      run_cgroup_test_fj.sh"
> contacts=""
> analysis=exit
> <<<test_output>>>
> incrementing stop
> Now, we start the test for cgroup...
> cat: cgroup_fj_testcases: No such file or directory
> <<<execution_status>>>
> initiation_status="ok"
> duration=0 termination_type=exited termination_id=0 corefile=no
> cutime=6 cstime=2
> <<<test_end>>>
> INFO: ltp-pan reported all tests PASS
> LTP Version: LTP-20100228
> 
> Eventhough the tests did not run, the results say all tests PASS. :)

For the above report here is the quick fix i can think.

commit 391e757d43b3ac33a4a435e319ee77b1daa6da76
Author: Rishikesh K Rajak <risrajak@linux.vnet.ibm.com>
Date:   Tue Mar 23 20:07:34 2010 +0530

    Fix the proper return for testcase.
    
    Reported By: Srinivasa R Chamarthy <schamart@linux.vnet.ibm.com>
    Signed-off By: Rishikesh K Rajak <risrajak@linux.vnet.ibm.com>

diff --git a/testcases/kernel/controllers/cgroup_fj/run_cgroup_test_fj.sh
b/testcases/kernel/controllers/cgroup_fj/run_cgroup_test_fj.sh
index 7445725..672f37c 100755
--- a/testcases/kernel/controllers/cgroup_fj/run_cgroup_test_fj.sh
+++ b/testcases/kernel/controllers/cgroup_fj/run_cgroup_test_fj.sh
@@ -129,4 +129,4 @@ do
        fi
 done
 
-exit 0;
+exit $ret;

> 
> -- 
> Srinivasa R Chamarthy (schamart@linux.vnet.ibm.com)
> Linux on System z (RedHat & Novell SuSE) CSVT,
> IBM India Systems & Technology Group/LTC - ISL,
> Bangalore - 560071, KA, INDIA. Off: +91-80-41776451 
> [ http://www.ibm.com/in/isl | http://www.ibm.com/linux/ltc ]
> 
> ------------------------------------------------------------------------------
> Download Intel&#174; Parallel Studio Eval
> Try the new software tools for yourself. Speed compiling, find bugs
> proactively, and fine-tune applications for parallel performance.
> See why Intel Parallel Studio got high marks during beta.
> http://p.sf.net/sfu/intel-sw-dev
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list

-- 
Thanks & Regards
Rishi
LTP Maintainer
IBM, LTC, Bangalore
Please join IRC #ltp @ irc.freenode.net

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list