From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCHv3 2/2] serial: Add driver for the Altera UART Date: Tue, 23 Mar 2010 14:54:59 -0700 Message-ID: <20100323145459.9894b1e6.akpm@linux-foundation.org> References: <15dc056891fb785001073bab4f9a0d0f3bf99af1.1267807169.git.klto@zhaw.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:56777 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754462Ab0CWVzL (ORCPT ); Tue, 23 Mar 2010 17:55:11 -0400 In-Reply-To: Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Tobias Klauser Cc: linux-serial@vger.kernel.org, gregkh@suse.de, nios2-dev@sopc.et.ntust.edu.tw, linux-kernel@vger.kernel.org On Fri, 5 Mar 2010 17:52:23 +0100 Tobias Klauser wrote: > + sigs |= (altera_uart_getppdcd(port->line) ? TIOCM_CD : 0); > + sigs |= (altera_uart_getppdtr(port->line) ? TIOCM_DTR : 0); We seem to be missing a few things here. drivers/serial/altera_uart.c: In function 'altera_uart_get_mctrl': drivers/serial/altera_uart.c:100: error: implicit declaration of function 'altera_uart_getppdcd' drivers/serial/altera_uart.c:101: error: implicit declaration of function 'altera_uart_getppdtr' drivers/serial/altera_uart.c: In function 'altera_uart_set_mctrl': drivers/serial/altera_uart.c:114: error: implicit declaration of function 'altera_uart_setppdtr'