All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: jeffrey.t.kirsher@intel.com, netdev@vger.kernel.org,
	gospo@redhat.com, alexander.h.duyck@intel.com
Subject: Re: [PATCH] skbuff: remove unused dma_head & dma_maps fields
Date: Wed, 24 Mar 2010 11:13:50 -0700 (PDT)	[thread overview]
Message-ID: <20100324.111350.158441178.davem@davemloft.net> (raw)
In-Reply-To: <1269413286.2915.107.camel@edumazet-laptop>

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 24 Mar 2010 07:48:06 +0100

> Le mardi 23 mars 2010 à 23:40 -0700, Jeff Kirsher a écrit :
>> From: Alexander Duyck <alexander.h.duyck@intel.com>
>> 
>> The dma map fields in the skb_shared_info structure no longer has any users
>> and can be dropped since it is making the skb_shared_info unecessarily larger.
>> 
>> Running slabtop show that we were using 4K slabs for the skb->head on x86_64 w/
>> an allocation size of 1522.  It turns out that the dma_head and dma_maps array
>> made skb_shared large enough that we had crossed over the 2k boundary with
>> standard frames and as such we were using 4k blocks of memory for all skbs.
>> 
>> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
>> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
>> ---
>> 
> 
> Thanks a lot for doing this cleanup !
> 
> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>

Yep, thanks indeed.  Applied!

      reply	other threads:[~2010-03-24 18:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-24  6:40 [PATCH] skbuff: remove unused dma_head & dma_maps fields Jeff Kirsher
2010-03-24  6:48 ` Eric Dumazet
2010-03-24 18:13   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100324.111350.158441178.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=alexander.h.duyck@intel.com \
    --cc=eric.dumazet@gmail.com \
    --cc=gospo@redhat.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.