From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Date: Wed, 24 Mar 2010 12:54:02 +0000 Subject: Re: [lm-sensors] [PATCH] hwmon: f71882fg: code cleanup Message-Id: <20100324135402.750cb197@hyperion.delvare> List-Id: References: <20100324084643.GB6368@salidar.me.mortis.eu> <1269421741-9706-1-git-send-email-me@mortis.eu> In-Reply-To: <1269421741-9706-1-git-send-email-me@mortis.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Giel van Schijndel Cc: Hans de Goede , Jonathan Cameron , Laurens Leemans , lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org On Wed, 24 Mar 2010 10:09:01 +0100, Giel van Schijndel wrote: > Some code cleanup: properly using previously defined functions, rather > than duplicating their code. > > Signed-off-by: Giel van Schijndel > --- > drivers/hwmon/f71882fg.c | 18 ++++++------------ > 1 files changed, 6 insertions(+), 12 deletions(-) > > diff --git a/drivers/hwmon/f71882fg.c b/drivers/hwmon/f71882fg.c > index 4230729..ca34e5c 100644 > --- a/drivers/hwmon/f71882fg.c > +++ b/drivers/hwmon/f71882fg.c > @@ -856,10 +856,8 @@ static inline int superio_inb(int base, int reg) > static int superio_inw(int base, int reg) > { > int val; > - outb(reg++, base); > - val = inb(base + 1) << 8; > - outb(reg, base); > - val |= inb(base + 1); > + val = superio_inb(base, reg) << 8; > + val |= superio_inb(base, reg + 1); > return val; > } > > @@ -905,10 +903,8 @@ static u16 f71882fg_read16(struct f71882fg_data *data, u8 reg) > { > u16 val; > > - outb(reg++, data->addr + ADDR_REG_OFFSET); > - val = inb(data->addr + DATA_REG_OFFSET) << 8; > - outb(reg, data->addr + ADDR_REG_OFFSET); > - val |= inb(data->addr + DATA_REG_OFFSET); > + val = f71882fg_read8(data, reg) << 8; > + val |= f71882fg_read8(data, reg + 1); > > return val; > } > @@ -921,10 +917,8 @@ static void f71882fg_write8(struct f71882fg_data *data, u8 reg, u8 val) > > static void f71882fg_write16(struct f71882fg_data *data, u8 reg, u16 val) > { > - outb(reg++, data->addr + ADDR_REG_OFFSET); > - outb(val >> 8, data->addr + DATA_REG_OFFSET); > - outb(reg, data->addr + ADDR_REG_OFFSET); > - outb(val & 255, data->addr + DATA_REG_OFFSET); > + f71882fg_write8(data, reg, val >> 8); > + f71882fg_write8(data, reg + 1, val & 0xff); > } > > static u16 f71882fg_read_temp(struct f71882fg_data *data, int nr) Applied, thanks. -- Jean Delvare _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756097Ab0CXMyL (ORCPT ); Wed, 24 Mar 2010 08:54:11 -0400 Received: from bamako.nerim.net ([62.4.17.28]:53321 "EHLO bamako.nerim.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755898Ab0CXMyH (ORCPT ); Wed, 24 Mar 2010 08:54:07 -0400 Date: Wed, 24 Mar 2010 13:54:02 +0100 From: Jean Delvare To: Giel van Schijndel Cc: Hans de Goede , Jonathan Cameron , Laurens Leemans , lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hwmon: f71882fg: code cleanup Message-ID: <20100324135402.750cb197@hyperion.delvare> In-Reply-To: <1269421741-9706-1-git-send-email-me@mortis.eu> References: <20100324084643.GB6368@salidar.me.mortis.eu> <1269421741-9706-1-git-send-email-me@mortis.eu> X-Mailer: Claws Mail 3.5.0 (GTK+ 2.14.4; i586-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 24 Mar 2010 10:09:01 +0100, Giel van Schijndel wrote: > Some code cleanup: properly using previously defined functions, rather > than duplicating their code. > > Signed-off-by: Giel van Schijndel > --- > drivers/hwmon/f71882fg.c | 18 ++++++------------ > 1 files changed, 6 insertions(+), 12 deletions(-) > > diff --git a/drivers/hwmon/f71882fg.c b/drivers/hwmon/f71882fg.c > index 4230729..ca34e5c 100644 > --- a/drivers/hwmon/f71882fg.c > +++ b/drivers/hwmon/f71882fg.c > @@ -856,10 +856,8 @@ static inline int superio_inb(int base, int reg) > static int superio_inw(int base, int reg) > { > int val; > - outb(reg++, base); > - val = inb(base + 1) << 8; > - outb(reg, base); > - val |= inb(base + 1); > + val = superio_inb(base, reg) << 8; > + val |= superio_inb(base, reg + 1); > return val; > } > > @@ -905,10 +903,8 @@ static u16 f71882fg_read16(struct f71882fg_data *data, u8 reg) > { > u16 val; > > - outb(reg++, data->addr + ADDR_REG_OFFSET); > - val = inb(data->addr + DATA_REG_OFFSET) << 8; > - outb(reg, data->addr + ADDR_REG_OFFSET); > - val |= inb(data->addr + DATA_REG_OFFSET); > + val = f71882fg_read8(data, reg) << 8; > + val |= f71882fg_read8(data, reg + 1); > > return val; > } > @@ -921,10 +917,8 @@ static void f71882fg_write8(struct f71882fg_data *data, u8 reg, u8 val) > > static void f71882fg_write16(struct f71882fg_data *data, u8 reg, u16 val) > { > - outb(reg++, data->addr + ADDR_REG_OFFSET); > - outb(val >> 8, data->addr + DATA_REG_OFFSET); > - outb(reg, data->addr + ADDR_REG_OFFSET); > - outb(val & 255, data->addr + DATA_REG_OFFSET); > + f71882fg_write8(data, reg, val >> 8); > + f71882fg_write8(data, reg + 1, val & 0xff); > } > > static u16 f71882fg_read_temp(struct f71882fg_data *data, int nr) Applied, thanks. -- Jean Delvare