From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luiz Capitulino Subject: Re: [Qemu-devel] [PATCH] qemu: jaso-parser: Output the content of invalid keyword Date: Wed, 24 Mar 2010 17:38:02 -0300 Message-ID: <20100324173802.58186de2@redhat.com> References: <1269433020-16055-1-git-send-email-akong@redhat.com> <4BAA03E3.8010505@twiddle.net> <20100324151205.GA13786@akong@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Amos Kong , kvm@vger.kernel.org, qemu-devel@nongnu.org, aurelien@aurel32.net, Richard Henderson To: Markus Armbruster Return-path: Received: from mx1.redhat.com ([209.132.183.28]:42065 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932295Ab0CXUiU (ORCPT ); Wed, 24 Mar 2010 16:38:20 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Wed, 24 Mar 2010 17:00:14 +0100 Markus Armbruster wrote: > Amos Kong writes: > > > When input some invialid word 'unknowcmd' through QMP port, qemu outputs this > > error message: > > "parse error: invalid keyword `%s'" > > This patch makes qemu output the content of invalid keyword, like: > > "parse error: invalid keyword `unknowcmd'" > > > > Signed-off-by: Amos Kong > > Looks good to me. > > Hint: it's best to put a version in the subject when you respin, like > [PATCH v2] ... Yes, and maintainers may miss a patch down a thread (and it's a good opportunity to fix the subject). From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NuXLL-00062w-Pi for qemu-devel@nongnu.org; Wed, 24 Mar 2010 16:38:23 -0400 Received: from [140.186.70.92] (port=60794 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NuXLJ-0005ya-Ho for qemu-devel@nongnu.org; Wed, 24 Mar 2010 16:38:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NuXLH-000810-1c for qemu-devel@nongnu.org; Wed, 24 Mar 2010 16:38:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30065) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NuXLG-00080w-Nq for qemu-devel@nongnu.org; Wed, 24 Mar 2010 16:38:18 -0400 Date: Wed, 24 Mar 2010 17:38:02 -0300 From: Luiz Capitulino Subject: Re: [Qemu-devel] [PATCH] qemu: jaso-parser: Output the content of invalid keyword Message-ID: <20100324173802.58186de2@redhat.com> In-Reply-To: References: <1269433020-16055-1-git-send-email-akong@redhat.com> <4BAA03E3.8010505@twiddle.net> <20100324151205.GA13786@akong@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: aurelien@aurel32.net, Amos Kong , qemu-devel@nongnu.org, kvm@vger.kernel.org, Richard Henderson On Wed, 24 Mar 2010 17:00:14 +0100 Markus Armbruster wrote: > Amos Kong writes: > > > When input some invialid word 'unknowcmd' through QMP port, qemu outputs this > > error message: > > "parse error: invalid keyword `%s'" > > This patch makes qemu output the content of invalid keyword, like: > > "parse error: invalid keyword `unknowcmd'" > > > > Signed-off-by: Amos Kong > > Looks good to me. > > Hint: it's best to put a version in the subject when you respin, like > [PATCH v2] ... Yes, and maintainers may miss a patch down a thread (and it's a good opportunity to fix the subject).