From: Oleg Nesterov <oleg@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Roland McGrath <roland@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm 1/1] proc: turn signal_struct->count into "int nr_threads"
Date: Wed, 24 Mar 2010 19:12:24 +0100 [thread overview]
Message-ID: <20100324181224.GA22456@redhat.com> (raw)
In-Reply-To: <20100324174936.GA21534@redhat.com>
On 03/24, Oleg Nesterov wrote:
>
> No functional changes, just s/atomic_t count/int nr_threads/.
Argh, I forgot to send "[PATCH 0/1]", please see below...
[PATCH -mm 0/1] proc: turn signal_struct->count into "int nr_threads"
Depends on
[PATCH -mm 1/2] proc_sched_show_task: use get_nr_threads()
[PATCH -mm 2/2] keyctl_session_to_parent: use thread_group_empty() to check singlethreadness
and on top of the trivial
[PATCH -mm] signals-clear-signal-tty-when-the-last-thread-exits.fix
I did "make allyesconfig" to test this change, but the compilation
failed because of unrelated bugs, and of course "count" is not really
grepable :/
However,
$ grep -nr --include=*.[ch] -E 'sig\w*->count' */ | grep -Ev 'sigh(and)?->count'
kernel/fork.c:827: atomic_set(&sig->count, 1);
and this "sig" above is in fact sighand.
Fortunately, if I missed some user of signal->count the necessary fix
will be really trivial. And I bet in this case that user should be
wrong anyway.
Oleg.
next prev parent reply other threads:[~2010-03-24 18:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-24 17:49 [PATCH -mm 1/1] proc: turn signal_struct->count into "int nr_threads" Oleg Nesterov
2010-03-24 18:12 ` Oleg Nesterov [this message]
2010-04-09 20:13 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100324181224.GA22456@redhat.com \
--to=oleg@redhat.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.