All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David Härdeman" <david@hardeman.nu>
To: linux-input@vger.kernel.org
Cc: dmitry.torokhov@gmail.com
Subject: Two questions regarding evdev
Date: Wed, 24 Mar 2010 21:53:32 +0100	[thread overview]
Message-ID: <20100324205332.GA7303@hardeman.nu> (raw)

I've been going over the evdev (drivers/input/evdev.c) code since I'm 
using it as inspiration for a small project I'm hacking on. So far I 
have two questions with regard to the code:

First, evdev_event passes a new event to all connected clients (writing 
it to each client's event fifo) and then calls wake_up_interruptible.  
However, given that all clients will have at least one new event to read 
after evdev_event is done, shouldn't wake_up_interruptible_all be called 
instead?

Second, evdev_poll never sets the POLLOUT flag, but evdev can accept 
writes (which will be passed to input_inject_event), so shouldn't the 
POLLOUT flag always be set?

Regards,
David


             reply	other threads:[~2010-03-24 21:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-24 20:53 David Härdeman [this message]
2010-03-24 21:41 ` Two questions regarding evdev Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100324205332.GA7303@hardeman.nu \
    --to=david@hardeman.nu \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.