All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexis Berlemont <alexis.berlemont@domain.hid>
To: Daniele Nicolodi <daniele@domain.hid>
Cc: xenomai-core <xenomai@xenomai.org>
Subject: Re: [Xenomai-core] [PULL REQUEST] analogy: bug fixes
Date: Thu, 25 Mar 2010 00:44:09 +0100	[thread overview]
Message-ID: <20100324234409.GA3247@domain.hid> (raw)
In-Reply-To: <4BA9EDEE.6070500@domain.hid>

Hi,
Daniele Nicolodi wrote:
> Alexis Berlemont wrote:
> > Daniele Nicolodi wrote:
> >> Alexis Berlemont wrote:
> >>> The following changes since commit 8cfc1103fe1cf9e700698e8230baf562ffb5cf06:
> >>>    Gilles Chanteperdrix (1):
> >>>          x86 syscalls: make __xn_get_eip a macro
> >>>
> >>> are available in the git repository at:
> >>>
> >>>    git://git.xenomai.org/xenomai-abe.git analogy
> >> Hello. Looking at your pull request, I see that my patch for correct
> >> buffer handling when using .stop_src  = TRIG_NONE is not included. Does
> >> the patch need some more work? Or it simply get lost on the way?
> > I have not forgotten it. I did not include it for two reasons:
> > - I have not found time to (fully) test it
> > - I wanted to properly modify the test program cmd_read so as to allow
> >   continuous acquisisitions 
> 
> Hi Alexis. Sorry for the late response. That's fine, I just wanted to be
> sure that the patch was not dropped by mistake. I'll test continuous
> output today and let you know if any other bugfix is necessary. I can
> also look into providing a patch for cmd_read and cmd_write.

If you want to test infinite acquisitions right now, you can clone my
git repository. I just pushed the modifications on it. I have not made
a pull request yet because I want to be sure there is no regression. 

Your patch did not integrate fixes for both directions (read and
write). So, I had to modify it.

I also modified cmd_read; with the option -S set to 0, an infinite
acquisition will be configured.

Any patch from you is welcome (cmd_write or anything else), so do not
hesitate to send them.

> 
> Cheers,
> -- 
> Daniele

-- 
Alexis.


  reply	other threads:[~2010-03-24 23:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-20  0:28 [Xenomai-core] [PULL REQUEST] analogy: bug fixes Alexis Berlemont
2010-03-20 12:56 ` Daniele Nicolodi
2010-03-21 20:59   ` Alexis Berlemont
2010-03-24 10:48     ` Daniele Nicolodi
2010-03-24 23:44       ` Alexis Berlemont [this message]
2010-03-25  0:05         ` Daniele Nicolodi
2010-03-25 13:46           ` Daniele Nicolodi
2010-03-28 22:47             ` Alexis Berlemont
2010-03-29 18:02               ` Daniele Nicolodi
  -- strict thread matches above, loose matches on Subject: below --
2010-07-07 23:13 [Xenomai-core] [PULL REQUEST] analogy " Alexis Berlemont
2010-07-08  9:14 ` Gilles Chanteperdrix
2010-07-09 13:15   ` Alexis Berlemont
2010-01-15  0:51 [Xenomai-core] [PULL REQUEST] analogy: " Alexis Berlemont

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100324234409.GA3247@domain.hid \
    --to=alexis.berlemont@domain.hid \
    --cc=daniele@domain.hid \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.