From: Jens Axboe <jens.axboe@oracle.com>
To: Divyesh Shah <dpshah@google.com>
Cc: linux-kernel@vger.kernel.org, nauman@google.com,
vgoyal@redhat.com, ctalbott@google.com
Subject: Re: [PATCH][v2] cfq-iosched: Add additional blktrace log messages in CFQ for easier debugging.
Date: Thu, 25 Mar 2010 15:44:18 +0100 [thread overview]
Message-ID: <20100325144418.GV5768@kernel.dk> (raw)
In-Reply-To: <20100325013655.6103.13377.stgit@austin.mtv.corp.google.com>
On Wed, Mar 24 2010, Divyesh Shah wrote:
> These have helped us debug some issues we've noticed in earlier IO
> controller versions and should be useful now as well. The extra logging
> covers:
> - idling behavior. Since there are so many conditions based on which we decide
> to idle or not, this patch adds a log message for some conditions that we've
> found useful.
> - workload slices and current prio and workload type
>
> Changelog from v1:
> o moved log message from cfq_set_active_queue() to __cfq_set_active_queue()
> o changed queue_count to st->count
Definitely makes sense, thanks I'll queue it up.
--
Jens Axboe
prev parent reply other threads:[~2010-03-25 14:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-25 1:38 [PATCH][v2] cfq-iosched: Add additional blktrace log messages in CFQ for easier debugging Divyesh Shah
2010-03-25 14:44 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100325144418.GV5768@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=ctalbott@google.com \
--cc=dpshah@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nauman@google.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.