From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754880Ab0CYUam (ORCPT ); Thu, 25 Mar 2010 16:30:42 -0400 Received: from ogre.sisk.pl ([217.79.144.158]:51370 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754792Ab0CYUal (ORCPT ); Thu, 25 Mar 2010 16:30:41 -0400 From: "Rafael J. Wysocki" To: Nigel Cunningham Subject: Re: [linux-pm] [RFC 03/15] PM / Hibernate: separate block_io Date: Thu, 25 Mar 2010 21:33:50 +0100 User-Agent: KMail/1.12.4 (Linux/2.6.34-rc2-rjw; KDE/4.3.5; x86_64; ; ) Cc: Jiri Slaby , linux-pm@lists.linux-foundation.org, linux-kernel@vger.kernel.org References: <1269361063-3341-1-git-send-email-jslaby@suse.cz> <201003252112.25204.rjw@sisk.pl> <4BABC3D1.1050104@crca.org.au> In-Reply-To: <4BABC3D1.1050104@crca.org.au> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201003252133.50206.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 25 March 2010, Nigel Cunningham wrote: > Hi. > > On 26/03/10 07:12, Rafael J. Wysocki wrote: > > On Thursday 25 March 2010, Nigel Cunningham wrote: > >> Hi again. > >> > >> On 25/03/10 09:58, Nigel Cunningham wrote: > >>> Hi. > >>> > >>> On 25/03/10 08:22, Jiri Slaby wrote: > >>>> On 03/24/2010 09:30 PM, Pavel Machek wrote: > >>>>> On Tue 2010-03-23 17:17:31, Jiri Slaby wrote: > >>>>>> +int sws_bio_read_page(pgoff_t page_off, void *addr, struct bio **bio_chain) > >>>>>> +{ > >>>>>> + return submit(READ, sws_resume_bdev, page_off * (PAGE_SIZE>> 9), > >>>>>> + virt_to_page(addr), bio_chain); > >>>>>> +} > >>>>> > >>>>> sws_ is kind of strange prefix. We were trying to get away from > >>>>> "swsuspend" name for quite some time... > >>>> > >>>> No problem to change the prefix to anything else. Do you (anybody) > >>>> suggest anything? > >>>> > >>> > >>> How about some abbreviation of hibernate? "hib"? > >> > >> On further reflection, how about "std" (suspend to disk)? I think that's > >> less ugly than the 'hib' suggestion :) > > > > But it also decodes as "standard" if someone is not in the right context. :-) > > Ah... > > > If the "bio" part of the name is not essential (ie. there's no conflicting name > > already), we could call it simply hibernate_read_page(). > > Yeah. So we're going with hibernate or hib_ if it needs abbreviating? I'd just use "hibernate" without abbreviating if reasonably possible. We can also use "image_" in some cases I guess. Rafael