Re: [PATCH 10/10] ath5k: Adaptive Noise Immunity (ANI) Implementation

[Bruno Randolf <br1@einfach.org>]

On Thursday 25 March 2010 19:59:11 Joerg Pommnitz wrote:
> Bruno Randolf <br1@...> writes:
> > +/* debugfs: ani */
> > +
> > +static ssize_t read_file_ani(struct file *file, char __user *user_buf,
> > +				   size_t count, loff_t *ppos)
> > +{
> > +	return simple_read_from_buffer(user_buf, count, ppos, buf, len);
> 
> ...
> 
> > +}
> 
> I would prefer a machine readable solution, e.g. individual files
> in an ANI directory with one value each.
> 
> > +static ssize_t write_file_ani(struct file *file,
> > +				 const char __user *userbuf,
> > +				 size_t count, loff_t *ppos)
> > +{
> 
> ...
> 
> > +	return count;
> > +}
> 
> Same as above: instead of a catch all with magic configuration words, use
> individual files with at least guessable values (e.g. 0/1 for
> enable/disable of individual features).

yes i agree with you and i mentioned this in my introdution message [PATCH 
0/0]. these are just debug files...

my question is which interface to use?

 iw? - probably not generic enough, allthough something like "sensitivity" 
could be useful to other drivers too?

 sysfs? configfs? - what is the interface of choice nowadays? ;)

bruno