From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Masami Hiramatsu <mhiramat@redhat.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Andrea Gelmini <andrea.gelmini@gelma.net>,
linux-doc@vger.kernel.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>,
Frederic Weisbecker <fweisbec@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 14/16] Tools perf probe-finder.c: duplicated include
Date: Fri, 26 Mar 2010 15:26:26 -0300 [thread overview]
Message-ID: <20100326182626.GL3625@ghostprotocols.net> (raw)
In-Reply-To: <4BACD64F.4090005@redhat.com>
Em Fri, Mar 26, 2010 at 11:44:15AM -0400, Masami Hiramatsu escreveu:
> KOSAKI Motohiro wrote:
> >> Hi Andrea,
> >>
> >> Andrea Gelmini wrote:
> >>> tools/perf/util/probe-finder.c: string.h is included more than once.
> >>
> >> Would you mean that <string.h> and "string.h" are duplicated?
> >> If so, NAK, sorry. Those are different, <string.h> is for
> >> /usr/include/string.h, and "string.h" is for tools/perf/util/string.h.
> >>
> >> Thank you,
> >
> > I think this discussion suggested "string.h" should be renameed more review
> > friendly name. probably.
String should be renamed, yes, I'll do that.
> Hmm, we'd better review files under tools/utils/include too. :(
> (not sure why we have those files, because some files includes
> headers from original include directory, as like as
> "../../include/linux/blahblah.h")
To share code with the kernel (rbtree.[ch], list.h).
- Arnaldo
next prev parent reply other threads:[~2010-03-26 18:26 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1269537767-7553-1-git-send-email-andrea.gelmini@gelma.net>
2010-03-25 17:22 ` [PATCH 01/16] ARM mach-at91: duplicated include Andrea Gelmini
2010-03-25 17:22 ` Andrea Gelmini
2010-03-29 20:35 ` Andrew Victor
2010-03-29 20:35 ` Andrew Victor
2010-03-25 17:22 ` [PATCH 02/16] ARM mach-mx3: " Andrea Gelmini
2010-03-25 17:22 ` Andrea Gelmini
2010-03-25 17:22 ` [PATCH 03/16] " Andrea Gelmini
2010-03-25 17:22 ` Andrea Gelmini
2010-03-25 17:22 ` [PATCH 04/16] x86 init_64.c: " Andrea Gelmini
2010-03-25 17:22 ` [PATCH 05/16] Docs hpet_example.c: duplicated includes Andrea Gelmini
2010-03-25 17:22 ` [PATCH 06/16] Staging: iio: Documentation/lis3l02dqbuffersimple.c: duplicated include Andrea Gelmini
2010-03-25 18:09 ` Jonathan Cameron
2010-03-25 17:22 ` [PATCH 07/16] Staging: sep: sep_driver.c: " Andrea Gelmini
2010-03-25 17:27 ` Randy Dunlap
2010-03-25 17:32 ` Andrea Gelmini
2010-03-25 17:22 ` [PATCH 08/16] Staging: wlan-ng: p80211wext.c: " Andrea Gelmini
2010-03-25 17:22 ` [PATCH 10/16] USB gadget r8a66597-udc.c: " Andrea Gelmini
2010-03-26 3:12 ` Paul Mundt
2010-03-25 17:22 ` [PATCH 11/16] XFS xfs_trace.c: " Andrea Gelmini
2010-03-25 17:22 ` Andrea Gelmini
2010-03-25 18:37 ` Alex Elder
2010-03-25 18:37 ` Alex Elder
2010-03-25 17:22 ` [PATCH 12/16] Scripts lex.c: remove extra spaces Andrea Gelmini
2010-03-26 13:15 ` Michal Marek
2010-03-26 13:23 ` Andrea Gelmini
2010-03-25 17:22 ` [PATCH 13/16] Tools perf builtin-trace.c: duplicated includes Andrea Gelmini
2010-03-26 8:00 ` Ingo Molnar
2010-03-26 13:27 ` Andrea Gelmini
2010-03-26 8:02 ` Ingo Molnar
2010-03-26 13:47 ` [PATCH 1/2] Tools perf builtin-trace.c: #includes cleanup Andrea Gelmini
2010-03-26 13:47 ` [PATCH 2/2] Tools perf builtin-trace.c: %Ld -> %lld Andrea Gelmini
2010-03-25 17:22 ` [PATCH 14/16] Tools perf probe-finder.c: duplicated include Andrea Gelmini
2010-03-25 17:42 ` Masami Hiramatsu
2010-03-25 17:45 ` Andrea Gelmini
2010-03-26 5:32 ` KOSAKI Motohiro
2010-03-26 15:44 ` Masami Hiramatsu
2010-03-26 18:26 ` Arnaldo Carvalho de Melo [this message]
2010-03-25 17:22 ` [PATCH 15/16] BTRFS ioctl.c: " Andrea Gelmini
2010-03-25 17:22 ` [PATCH 16/16] Video omap lcd_omap3beagle.c: " Andrea Gelmini
2010-03-25 17:22 ` Andrea Gelmini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100326182626.GL3625@ghostprotocols.net \
--to=acme@infradead.org \
--cc=a.p.zijlstra@chello.nl \
--cc=andrea.gelmini@gelma.net \
--cc=fweisbec@gmail.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.