From: Alasdair G Kergon <agk@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] Remove vgname check from _find_vg_rlocn and just return the rlocn slot.
Date: Fri, 26 Mar 2010 18:31:39 +0000 [thread overview]
Message-ID: <20100326183139.GS5259@agk-dp.fab.redhat.com> (raw)
In-Reply-To: <1269625126-18152-1-git-send-email-dwysocha@redhat.com>
On Fri, Mar 26, 2010 at 01:38:46PM -0400, Dave Wysochanski wrote:
> Unclear what the purpose of this check was/is. Removing it allows for easier
> refactoring, fixes at least one bug, and at least breaks no tests. If it
> covers and important case, we should add a comment and/or testcase.
The on-disk layout supports multiple mdas for different VGs stored on the same
disk. But at the moment we only use one.
[Create a test case: PV with 2 mdas, and different vgname in each...current
code should ignore the 2nd one, maybe overwriting it with copy of first, I'm
not sure.]
> - /* FIXME Loop through rlocns two-at-a-time. List null-terminated. */
> - /* FIXME Ignore if checksum incorrect!!! */
FIXME removed, so does the patch now validate the checksum?
I think the vgname validation is still needed on almost all occasions.
Only the 'tell me which VG is in this mda' case doesn't want it.
Alasdair
next prev parent reply other threads:[~2010-03-26 18:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-26 13:56 [PATCH] Fix vg_write/vg_commit to not reset position in metadata ring buffer on vgrename Peter Rajnoha
2010-03-26 16:15 ` Dave Wysochanski
2010-03-26 17:38 ` [PATCH] Remove vgname check from _find_vg_rlocn and just return the rlocn slot Dave Wysochanski
2010-03-26 18:31 ` Alasdair G Kergon [this message]
2010-03-26 23:01 ` [PATCH] Fix vg_write/vg_commit to not reset position in metadata ring buffer on vgrename Peter Rajnoha
2010-03-27 0:18 ` Alasdair G Kergon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100326183139.GS5259@agk-dp.fab.redhat.com \
--to=agk@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.