From: akpm@linux-foundation.org
To: holt@sgi.com, aarcange@redhat.com, chrisw@redhat.com,
hugh.dickins@tiscali.co.uk, ieidus@redhat.com,
mm-commits@vger.kernel.org
Subject: [merged] mm-ksmc-is-doing-an-unneeded-_notify-in-write_protect_page.patch removed from -mm tree
Date: Fri, 26 Mar 2010 12:36:30 -0400 [thread overview]
Message-ID: <201003261937.o2QJbToH016609@imap1.linux-foundation.org> (raw)
The patch titled
mm/ksm.c is doing an unneeded _notify in write_protect_page.
has been removed from the -mm tree. Its filename was
mm-ksmc-is-doing-an-unneeded-_notify-in-write_protect_page.patch
This patch was dropped because it was merged into mainline or a subsystem tree
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: mm/ksm.c is doing an unneeded _notify in write_protect_page.
From: Robin Holt <holt@sgi.com>
ksm.c's write_protect_page implements a lockless means of verifying a page
does not have any users of the page which are not accounted for via other
kernel tracking means. It does this by removing the writable pte with TLB
flushes, checking the page_count against the total known users, and then
using set_pte_at_notify to make it a read-only entry.
An unneeded mmu_notifier callout is made in the case where the known users
does not match the page_count. In that event, we are inserting the
identical pte and there is no need for the set_pte_at_notify, but rather
the simpler set_pte_at suffices.
Signed-off-by: Robin Holt <holt@sgi.com>
Acked-by: Izik Eidus <ieidus@redhat.com>
Acked-by: Andrea Arcangeli <aarcange@redhat.com>
Acked-by: Hugh Dickins <hugh.dickins@tiscali.co.uk>
Cc: Chris Wright <chrisw@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/ksm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN mm/ksm.c~mm-ksmc-is-doing-an-unneeded-_notify-in-write_protect_page mm/ksm.c
--- a/mm/ksm.c~mm-ksmc-is-doing-an-unneeded-_notify-in-write_protect_page
+++ a/mm/ksm.c
@@ -751,7 +751,7 @@ static int write_protect_page(struct vm_
* page
*/
if (page_mapcount(page) + 1 + swapped != page_count(page)) {
- set_pte_at_notify(mm, addr, ptep, entry);
+ set_pte_at(mm, addr, ptep, entry);
goto out_unlock;
}
entry = pte_wrprotect(entry);
_
Patches currently in -mm which might be from holt@sgi.com are
origin.patch
reply other threads:[~2010-03-26 19:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201003261937.o2QJbToH016609@imap1.linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aarcange@redhat.com \
--cc=chrisw@redhat.com \
--cc=holt@sgi.com \
--cc=hugh.dickins@tiscali.co.uk \
--cc=ieidus@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.