Re: [PATCH 00/14] tracing: add compat syscall support v3

[Frederic Weisbecker <fweisbec@gmail.com>]

On Tue, Mar 16, 2010 at 01:46:08PM -0400, Jason Baron wrote:
> Hi,
> 
> Re-post to add infrastructure for compat syscall event tracing support. This
> patch series also adds x86_64 arch specific support as an example consumer
> of the new infrastructure.
> 
> Arches can request compat syscall tracing by setting: 
> __HAVE_ARCH_FTRACE_COMPAT_SYSCALLS, if CONFIG_COMPAT and CONFIG_FTRACE_SYSCALLS
> are set. Arches then need to implement the following interfaces:
> 
> 1) int is_compat_task(void);
>   - most arches seem to have this already
> 2) unsigned long arch_compat_syscall_addr(int nr);
>   - returns a pointer to the compat syscall entry corresponding to syscall 'nr'
> 3) int NR_syscalls_compat;
>   - number of entries in the compat syscall table.
> 
> thanks,
> 
> -Jason
> 
> Changes in v3:
> 
>  - create a separate "compat_syscalls" event subsystem
>  - ARCH_COMPAT_SYSCALL_DEFINE#N() tacks "sys32" to start of syscall name
>  - COMPAT_SYSCALL_DEFINE#N() tacks "compat_sys" to start of syscall name
>  - both above macros create perf events as: [enter|exit]_compat_sys_blah
>  - non-compat syscall naming changes to: [enter|exit]_sys_blah
>  - removes any unreferenced compat syscalls from debugfs



Other than the small comments I had, it's a very nice stuff.
Just waiting for your next iteration before applying.

Thanks!